Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump a buncha versions (draft) #131

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Bump a buncha versions (draft) #131

wants to merge 6 commits into from

Conversation

grantnorwood
Copy link
Collaborator

@grantnorwood grantnorwood commented Aug 9, 2024

We haven't bumped our deps in a while, so I figure this will help us all have a clean slate (and clean conscience!)

What changed

  • bumped Node.js from 18.* to 20.16.*.nvmrc is pinned to just the major + minor for development, but I think pinning to 20.16.0 will be easier in ci/cd stuff.
  • bumped only the minor & patch versions in package.json to something safe & reasonable (bumping major version can be a future thing)
  • ran npx playwright install to update to the latest browsers

How I tested it

  • rm -rf node_modulesnpm run cleannpm i
  • Ran the most important scripts in package.json
    • npm run dev
    • npm run test
    • npm run test:e2e
    • 🤔 npm run lint
      • We need to downgrade our TypeScript to make this warning go away:

        WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
        
        You may find that it works just fine, or you may not.
        
        SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.1.0
        
        YOUR TYPESCRIPT VERSION: 5.5.4
        

Ideas for future improvement

  • Update package major versions
  • Configure Playwright to run its ci/cd tests against the staging & prod sites after deployment, it's currently running locally

@grantnorwood grantnorwood added the staging Applying this label to PRs on creation, or after, will cause a staging deploy to occur. label Aug 9, 2024
@grantnorwood grantnorwood had a problem deploying to remixaustin-com-pr-131 August 9, 2024 20:57 — with GitHub Actions Failure
@grantnorwood
Copy link
Collaborator Author

grantnorwood commented Aug 9, 2024

Deploying to staging via Fly is broken, looks like I need to update some GitHub Actions, or call the cli directly.

+ flyctl deploy --config fly.toml --app remixaustin-com-pr-131 --region dfw --image registry.fly.io/remixaustin-com-prod:131-merge-9f1ed0b1d8a4917e859c74804618322993ac127f --strategy immediate

Error: unknown flag: --region

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Applying this label to PRs on creation, or after, will cause a staging deploy to occur.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant