-
Notifications
You must be signed in to change notification settings - Fork 2
Show lens name instead of wallet address in conversation list when th… #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e user doesn't have an ENS name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was a misclick on my behalf, see this one instead #119 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The
peerAddressDisplay
prop is a manual override for what gets displayed so it shouldn't be removed - The
responsiveName
anduseEnsName
hooks should be removed in favor of theuseRelayId
hook (We don't need to use all 3, we can just use the 1). - The logic for deciding what to show should be straightforward: "if we have an ENS name show that, if we have a Lens name, show that, otherwise show the address"
useRelayId doesn't truncate anything and all 3 forms (ens, lens, address) need to be truncated 3 different ways, so I'm assuming I'll import truncateName, truncateAddress and write a new function for truncate lens and use those along with useRelayId and everything should work that way along with what you mentioned above. Does that sound about right? @killthebuddh4 |
Yep that sounds about right. |
The code has been updated @killthebuddh4 Let me know if this works. It seems to be everything we discussed. I slightly adjusted the ens function in the address.ts so when it's truncated there are 3 dots instead of 4. The output is the same as the screenshot I posted above |
Closes #114