Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance with cache length in a array loop #1654

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bindActionCreators.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default function bindActionCreators(actionCreators, dispatch) {

var keys = Object.keys(actionCreators)
var boundActionCreators = {}
for (var i = 0; i < keys.length; i++) {
for (var i = 0, l = keys.length; i < l; i++) {
var key = keys[i]
var actionCreator = actionCreators[key]
if (typeof actionCreator === 'function') {
Expand Down
16 changes: 9 additions & 7 deletions src/combineReducers.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ function getUnexpectedStateShapeWarningMessage(inputState, reducers, action) {
}

var unexpectedKeys = Object.keys(inputState).filter(key => !reducers.hasOwnProperty(key))

if (unexpectedKeys.length > 0) {
var unexpectedKeysLength = unexpectedKeys.length
if (unexpectedKeysLength > 0) {
return (
`Unexpected ${unexpectedKeys.length > 1 ? 'keys' : 'key'} ` +
`Unexpected ${unexpectedKeysLength > 1 ? 'keys' : 'key'} ` +
`"${unexpectedKeys.join('", "')}" found in ${argumentName}. ` +
`Expected to find one of the known reducer keys instead: ` +
`"${reducerKeys.join('", "')}". Unexpected keys will be ignored.`
Expand All @@ -47,7 +47,9 @@ function getUnexpectedStateShapeWarningMessage(inputState, reducers, action) {
}

function assertReducerSanity(reducers) {
Object.keys(reducers).forEach(key => {
var reducerKeys = Object.keys(reducers)
for (var i = 0, l = reducerKeys.length; i < l; i++) {
var key = reducerKeys[i]
var reducer = reducers[key]
var initialState = reducer(undefined, { type: ActionTypes.INIT })

Expand All @@ -71,7 +73,7 @@ function assertReducerSanity(reducers) {
`action type. The initial state may not be undefined.`
)
}
})
}
}

/**
Expand All @@ -93,7 +95,7 @@ function assertReducerSanity(reducers) {
export default function combineReducers(reducers) {
var reducerKeys = Object.keys(reducers)
var finalReducers = {}
for (var i = 0; i < reducerKeys.length; i++) {
for (var i = 0, l = reducerKeys.length; i < l; i++) {
var key = reducerKeys[i]
if (typeof reducers[key] === 'function') {
finalReducers[key] = reducers[key]
Expand Down Expand Up @@ -122,7 +124,7 @@ export default function combineReducers(reducers) {

var hasChanged = false
var nextState = {}
for (var i = 0; i < finalReducerKeys.length; i++) {
for (var i = 0, l = finalReducerKeys.length; i < l; i++) {
var key = finalReducerKeys[i]
var reducer = finalReducers[key]
var previousStateForKey = state[key]
Expand Down
2 changes: 1 addition & 1 deletion src/createStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export default function createStore(reducer, initialState, enhancer) {
}

var listeners = currentListeners = nextListeners
for (var i = 0; i < listeners.length; i++) {
for (var i = 0, l = listeners.length; i < l; i++) {
listeners[i]()
}

Expand Down