feat: add GEARSET.DAT parsing (only content, it needs libxivdat to parse the wrapper) #7
+309
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FWIW your solution looks fine for now, I have a similar problem in char save data as I have to map between it's own integers and the race/subrace/gender enums. If I have a solution I like then I'll just clean it all up. LGTM, but you need to add REUSE metadata at the top of your new module - see the others for an example. I also appreciate you including an example file to test with! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6
I kept
GearSlotTypeindependent fromSlotto avoid issues inchardat.rsbut maybe it should be unified?There are a bunch of flags and values I couldn't guess from the values so I marked them as "unknown".
Apart from this, you should be able to parse your own
GEARSET.DAT😄