From 5974cf9fd2fab7938749d1716307a1a43fa06e85 Mon Sep 17 00:00:00 2001 From: Rafal Korepta Date: Tue, 6 Aug 2024 16:12:15 +0200 Subject: [PATCH 1/2] Remove tiered storage test In Redpanda starting from 24.2.1 it has self configuration check which shutdown whole Redpanda process if tiered storage have fake API credentials. The error from Redpanda: ``` ERROR 2024-08-06 14:03:28,285 [shard 0:main] s3 - s3_client.cc:622 - Couldn't reach S3 storage with either path style or virtual_host style requests. ERROR 2024-08-06 14:03:28,285 [shard 0:main] client_pool - client_pool.cc:79 - Self configuration of the cloud storage client failed. This indicates a misconfiguration of Redpanda. Aborting start-up ... ``` --- charts/redpanda/chart_test.go | 40 ----------------------------------- 1 file changed, 40 deletions(-) diff --git a/charts/redpanda/chart_test.go b/charts/redpanda/chart_test.go index e470c848b0..3cb035f3e0 100644 --- a/charts/redpanda/chart_test.go +++ b/charts/redpanda/chart_test.go @@ -46,46 +46,6 @@ func TestChart(t *testing.T) { h := helmtest.Setup(t) - t.Run("tiered-storage-secrets", func(t *testing.T) { - ctx := testutil.Context(t) - - env := h.Namespaced(t) - - credsSecret, err := kube.Create(ctx, env.Ctl(), TieredStorageSecret(env.Namespace())) - require.NoError(t, err) - - rpRelease := env.Install(ctx, redpandaChart, helm.InstallOptions{ - Values: redpanda.PartialValues{ - Config: &redpanda.PartialConfig{ - Node: redpanda.PartialNodeConfig{ - "developer_mode": true, - }, - }, - External: &redpanda.PartialExternalConfig{Enabled: ptr.To(false)}, - }, - }) - - rpk := Client{Ctl: env.Ctl(), Release: &rpRelease} - - config, err := rpk.ClusterConfig(ctx) - require.NoError(t, err) - require.Equal(t, false, config["cloud_storage_enabled"]) - - rpRelease = env.Upgrade(redpandaChart, rpRelease, helm.UpgradeOptions{Values: TieredStorageStatic(t)}) - - config, err = rpk.ClusterConfig(ctx) - require.NoError(t, err) - require.Equal(t, true, config["cloud_storage_enabled"]) - require.Equal(t, "static-access-key", config["cloud_storage_access_key"]) - - rpRelease = env.Upgrade(redpandaChart, rpRelease, helm.UpgradeOptions{Values: TieredStorageSecretRefs(t, credsSecret)}) - - config, err = rpk.ClusterConfig(ctx) - require.NoError(t, err) - require.Equal(t, true, config["cloud_storage_enabled"]) - require.Equal(t, "from-secret-access-key", config["cloud_storage_access_key"]) - }) - t.Run("mtls-using-cert-manager", func(t *testing.T) { ctx := testutil.Context(t) From 916b024b42de2fd9c3fcefc2a7de90ddc23545c3 Mon Sep 17 00:00:00 2001 From: Rafal Korepta Date: Tue, 6 Aug 2024 16:50:46 +0200 Subject: [PATCH 2/2] Include integration test suite into block PR from merging --- .github/workflows/pull_requests.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull_requests.yaml b/.github/workflows/pull_requests.yaml index 847e6a7765..a73cdcd98b 100644 --- a/.github/workflows/pull_requests.yaml +++ b/.github/workflows/pull_requests.yaml @@ -137,11 +137,12 @@ jobs: - test-charts-kminion - test-charts-operator - test-charts-redpanda + - test-charts-redpanda-integration - test-go runs-on: ubuntu-22.04 steps: - name: Summarize the results of the test matrix pass/fail uses: re-actors/alls-green@release/v1 with: - allowed-skips: test-go, test-charts-connectors, test-charts-kminion, test-charts-operator, test-charts-redpanda + allowed-skips: test-go, test-charts-connectors, test-charts-kminion, test-charts-operator, test-charts-redpanda, test-charts-redpanda-integration jobs: ${{ toJSON(needs)}}