UnusedForeachValueToArrayKeysRector removes values that are used

[sreichel]

Bug Report

Subject	Details
Rector version	v1.2.1
Rule	UnusedForeachValueToArrayKeysRector

This rule also removes values that are later used in that method ...

Minimal PHP Code Causing Issue

Demo-page returns 500 error ...

See

• https://github.com/sreichel/magento-lts/pull/1/files#diff-f41ae70f01bb5969abbb4c815813e7393574ddb38562951b6012b0c1a8a84a5d (search for app/code/core/Mage/Core/Model/Date.php)
• https://github.com/sreichel/magento-lts/actions/runs/10020627174/job/27698413846

Expected Behaviour

If the value is used lat,er it should be skipped.

[samsonasik]

Demo page should be fixed now, could you retry?

[sreichel]

Nice. Thanks.

https://getrector.com/demo/5f7fe2d8-df83-4f4d-baa2-36d6188e5b0a

[sreichel]

Another one ... &$storeCode changed to &$storeId ... ?!?

$storeCode isnt used later. Did not test it, but this looks wrong ...

[samsonasik]

Could you create example at https://3v4l.org/ that show invalid result on reference?

[sreichel]

Yes, i will do. But 2nd one is strange ... there is similiar code in the same file (unsed referernce) that is not changed. Gimme one or two days to test.

[samsonasik]

No worries, we can fix one by one with new issue if needed