-
-
Notifications
You must be signed in to change notification settings - Fork 708
/
Copy pathReadOnlyClassRector.php
275 lines (273 loc) · 8.94 KB
/
ReadOnlyClassRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
<?php
declare (strict_types=1);
namespace Rector\Php82\Rector\Class_;
use PhpParser\Node;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Param;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Property;
use PHPStan\Analyser\Scope;
use PHPStan\BetterReflection\Reflection\Adapter\ReflectionProperty;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\ReflectionProvider;
use Rector\NodeAnalyzer\ClassAnalyzer;
use Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer;
use Rector\Php81\Enum\AttributeName;
use Rector\Php81\NodeManipulator\AttributeGroupNewLiner;
use Rector\PHPStan\ScopeFetcher;
use Rector\Privatization\NodeManipulator\VisibilityManipulator;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\MethodName;
use Rector\ValueObject\PhpVersionFeature;
use Rector\ValueObject\Visibility;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\Php82\Rector\Class_\ReadOnlyClassRector\ReadOnlyClassRectorTest
*/
final class ReadOnlyClassRector extends AbstractRector implements MinPhpVersionInterface
{
/**
* @readonly
*/
private ClassAnalyzer $classAnalyzer;
/**
* @readonly
*/
private VisibilityManipulator $visibilityManipulator;
/**
* @readonly
*/
private PhpAttributeAnalyzer $phpAttributeAnalyzer;
/**
* @readonly
*/
private ReflectionProvider $reflectionProvider;
/**
* @readonly
*/
private AttributeGroupNewLiner $attributeGroupNewLiner;
public function __construct(ClassAnalyzer $classAnalyzer, VisibilityManipulator $visibilityManipulator, PhpAttributeAnalyzer $phpAttributeAnalyzer, ReflectionProvider $reflectionProvider, AttributeGroupNewLiner $attributeGroupNewLiner)
{
$this->classAnalyzer = $classAnalyzer;
$this->visibilityManipulator = $visibilityManipulator;
$this->phpAttributeAnalyzer = $phpAttributeAnalyzer;
$this->reflectionProvider = $reflectionProvider;
$this->attributeGroupNewLiner = $attributeGroupNewLiner;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Decorate read-only class with `readonly` attribute', [new CodeSample(<<<'CODE_SAMPLE'
final class SomeClass
{
public function __construct(
private readonly string $name
) {
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
final readonly class SomeClass
{
public function __construct(
private string $name
) {
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node) : ?Node
{
$scope = ScopeFetcher::fetch($node);
if ($this->shouldSkip($node, $scope)) {
return null;
}
$this->visibilityManipulator->makeReadonly($node);
$constructClassMethod = $node->getMethod(MethodName::CONSTRUCT);
if ($constructClassMethod instanceof ClassMethod) {
foreach ($constructClassMethod->getParams() as $param) {
$this->visibilityManipulator->removeReadonly($param);
if ($param->attrGroups !== []) {
$this->attributeGroupNewLiner->newLine($this->file, $param);
}
}
}
foreach ($node->getProperties() as $property) {
$this->visibilityManipulator->removeReadonly($property);
if ($property->attrGroups !== []) {
$this->attributeGroupNewLiner->newLine($this->file, $property);
}
}
if ($node->attrGroups !== []) {
$this->attributeGroupNewLiner->newLine($this->file, $node);
}
return $node;
}
public function provideMinPhpVersion() : int
{
return PhpVersionFeature::READONLY_CLASS;
}
/**
* @return ClassReflection[]
*/
private function resolveParentClassReflections(Scope $scope) : array
{
$classReflection = $scope->getClassReflection();
if (!$classReflection instanceof ClassReflection) {
return [];
}
return $classReflection->getParents();
}
/**
* @param Property[] $properties
*/
private function hasNonTypedProperty(array $properties) : bool
{
foreach ($properties as $property) {
// properties of readonly class must always have type
if ($property->type === null) {
return \true;
}
}
return \false;
}
private function shouldSkip(Class_ $class, Scope $scope) : bool
{
$classReflection = $scope->getClassReflection();
if (!$classReflection instanceof ClassReflection) {
return \true;
}
if ($this->shouldSkipClass($class)) {
return \true;
}
$parents = $this->resolveParentClassReflections($scope);
if (!$class->isFinal()) {
return !$this->isExtendsReadonlyClass($parents);
}
foreach ($parents as $parent) {
if (!$parent->isReadOnly()) {
return \true;
}
}
$properties = $class->getProperties();
if ($this->hasWritableProperty($properties)) {
return \true;
}
if ($this->hasNonTypedProperty($properties)) {
return \true;
}
if ($this->shouldSkipConsumeTraitProperty($class)) {
return \true;
}
$constructClassMethod = $class->getMethod(MethodName::CONSTRUCT);
if (!$constructClassMethod instanceof ClassMethod) {
// no __construct means no property promotion, skip if class has no property defined
return $properties === [];
}
$params = $constructClassMethod->getParams();
if ($params === []) {
// no params means no property promotion, skip if class has no property defined
return $properties === [];
}
return $this->shouldSkipParams($params);
}
private function shouldSkipConsumeTraitProperty(Class_ $class) : bool
{
$traitUses = $class->getTraitUses();
foreach ($traitUses as $traitUse) {
foreach ($traitUse->traits as $trait) {
$traitName = $trait->toString();
// trait not autoloaded
if (!$this->reflectionProvider->hasClass($traitName)) {
return \true;
}
$traitClassReflection = $this->reflectionProvider->getClass($traitName);
$nativeReflection = $traitClassReflection->getNativeReflection();
if ($this->hasReadonlyProperty($nativeReflection->getProperties())) {
return \true;
}
}
}
return \false;
}
/**
* @param ReflectionProperty[] $properties
*/
private function hasReadonlyProperty(array $properties) : bool
{
foreach ($properties as $property) {
if (!$property->isReadOnly()) {
return \true;
}
}
return \false;
}
/**
* @param ClassReflection[] $parents
*/
private function isExtendsReadonlyClass(array $parents) : bool
{
foreach ($parents as $parent) {
if ($parent->isReadOnly()) {
return \true;
}
}
return \false;
}
/**
* @param Property[] $properties
*/
private function hasWritableProperty(array $properties) : bool
{
foreach ($properties as $property) {
if (!$property->isReadonly()) {
return \true;
}
}
return \false;
}
private function shouldSkipClass(Class_ $class) : bool
{
// need to have test fixture once feature added to nikic/PHP-Parser
if ($this->visibilityManipulator->hasVisibility($class, Visibility::READONLY)) {
return \true;
}
if ($this->classAnalyzer->isAnonymousClass($class)) {
return \true;
}
if ($this->phpAttributeAnalyzer->hasPhpAttribute($class, AttributeName::ALLOW_DYNAMIC_PROPERTIES)) {
return \true;
}
return $class->extends instanceof FullyQualified && !$this->reflectionProvider->hasClass($class->extends->toString());
}
/**
* @param Param[] $params
*/
private function shouldSkipParams(array $params) : bool
{
foreach ($params as $param) {
// has non-readonly property promotion
if (!$this->visibilityManipulator->hasVisibility($param, Visibility::READONLY) && $param->isPromoted()) {
return \true;
}
// type is missing, invalid syntax
if ($param->type === null) {
return \true;
}
}
return \false;
}
}