Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Shl / Shr impls out of support into main lib #327

Closed
Evalir opened this issue Oct 3, 2023 · 1 comment · Fixed by #328
Closed

Move Shl / Shr impls out of support into main lib #327

Evalir opened this issue Oct 3, 2023 · 1 comment · Fixed by #328
Assignees
@prestwich
Labels
good first issue Good for newcomers refactor Can be written more cleanly

Comments

@Evalir
Copy link
Contributor

Evalir commented Oct 3, 2023

It would be nice to support the Shl and Shr traits for uints.
@prestwich prestwich added good first issue Good for newcomers refactor Can be written more cleanly labels Oct 3, 2023
@prestwich
Copy link
Collaborator

prestwich commented Oct 3, 2023 •
edited
Loading

Shl<usize> and Shr<usize> are currently impled in bits.rs

Shl<u32> and Shr<u32> are currently impld in support/num_traits.rs with TODOs to move out of support. I'll close those issues in favor of this one.

Supersedes #300 & #301

@prestwich prestwich changed the title Feature request: support Shl / Shr for Uint Move Shl / Shr impls out of support into main lib Oct 3, 2023
This was referenced Oct 3, 2023
Closed
Closed
@prestwich prestwich self-assigned this Oct 3, 2023
@prestwich prestwich mentioned this issue Oct 3, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prestwich prestwich

Labels
good first issue Good for newcomers refactor Can be written more cleanly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: more Shl+Shr impls recmo/uint
2 participants
@prestwich @Evalir