Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests or lock foundry CI version #74

Open
dtbuchholz opened this issue Feb 1, 2025 · 1 comment
Open

Fix tests or lock foundry CI version #74

dtbuchholz opened this issue Feb 1, 2025 · 1 comment

Comments

@dtbuchholz
Copy link
Contributor

dtbuchholz commented Feb 1, 2025 •
edited
Loading

See the error in https://github.com/recallnet/contracts/actions/runs/13085476261/job/36516308102#step:8:1

The error mentions that ValidatorGater is using testFail.., which no longer exists. We use the latest nightly version in our CI, so maybe that's why it failed.

[FAIL: `testFail*` has been removed. Consider changing to test_Revert[If|When]_Condition and expecting a revert] Found 1 instances: testFailUnauthorizedApprove (gas: 0)
@dtbuchholz
Copy link
Contributor Author

dtbuchholz commented Feb 1, 2025 •
edited
Loading

cc @avichalp

I'm not sure why this happened all of the sudden...maybe a new foundry nightly version was released between the time I pushed my latest PR (the test passed) and merged it (test failed).

@avichalp avichalp mentioned this issue Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dtbuchholz