test: cleaning up our jest config #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
weird, I could have sworn I tried it without a preset value in #610 but maybe not. maybe ts-jest finally got their shit together?
|
yea maybe |
|
also very bummed that #617 is still happening 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
While upgrading
oasto Jest 29 I also encountered the same issue we had here wherets-jestwasn't picking up ourtsconfig.jsonfile. Turns out that because we're setting uptransformon.tsfiles ourselves we don't need this extrapresetsconfig as it's already being loaded from thetransformconfig. Loading both of these was causing the first preset to get loaded without unit testtsconfig.Kind of an annoying gotcha but all tests should still be passing with this change.