Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add guides alias #647

Merged
merged 6 commits into from
Oct 27, 2022

Conversation

kanadgupta
Copy link
Member

🚥 Fix RM-5581

🧰 Changes

Adds an alias for the docs family of commands called guides, as well as some corresponding documentation touch-ups. Note that the docs:edit command doesn't have a corresponding alias since that command is now deprecated (see #646).

🧬 QA & Testing

Does the alias'ing approach + the corresponding docs look good?

@kanadgupta kanadgupta requested a review from erunion October 27, 2022 22:58
@kanadgupta kanadgupta added command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands enhancement New feature or request documentation Improvements or additions to documentation labels Oct 27, 2022
versions: {
description: 'Versions',
commands: [],
},
categories: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rearranged this so the categories in the help screen align with the README.md command reference.

@@ -16,11 +16,11 @@ export function getCategories(): Record<
> {
return {
apis: {
description: 'Upload OpenAPI/Swagger definitions',
description: 'OpenAPI / Swagger',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wayyyy cleaner of a header, good lordt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the amount of little oversights on the main help screen that we don't notice for literal years lmao

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤡

@kanadgupta kanadgupta merged commit d412a04 into main Oct 27, 2022
@kanadgupta kanadgupta deleted the kanad/rm-5581-deprecate-docs-in-favor-of-guides branch October 27, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants