feat: upgrading oas-normalize to pull in its new TS typings #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Aug 10, 2022
| @@ -1,9 +1,8 @@ | |||
| import fs from 'fs'; | |||
|
|
|||
| import chalk from 'chalk'; | |||
| import ora from 'ora'; | |||
|
|
|||
| import OASNormalize from 'oas-normalize'; | |||
There was a problem hiding this comment.
This wasn't being sorted before ora before because the sinkhole exclusion was causing the import/order rule to think that it was a local package.
erunion
commented
Aug 10, 2022
| @@ -69,7 +68,7 @@ export default async function prepareOas(path: string, command: 'openapi' | 'val | |||
| let bundledSpec = ''; | |||
|
|
|||
| if (command === 'openapi') { | |||
| bundledSpec = await oas.bundle().then((res: Record<string, unknown>) => { | |||
There was a problem hiding this comment.
Removed the type here because OASNormalize.bundle returns an OpenAPI.Document now and Record is incompatible with that.
kanadgupta
approved these changes
Aug 10, 2022
| @@ -69,7 +68,7 @@ export default async function prepareOas(path: string, command: 'openapi' | 'val | |||
| let bundledSpec = ''; | |||
|
|
|||
| if (command === 'openapi') { | |||
| bundledSpec = await oas.bundle().then((res: Record<string, unknown>) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
I rewrote oas-normalize last night in TypeScript (readmeio/oas-normalize#210) so we no longer need to have a typing sinkhole exclusion for it.