Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): add ability to override host + hub #535

Merged
merged 1 commit into from
Jul 15, 2022
Merged

feat(config): add ability to override host + hub #535

merged 1 commit into from
Jul 15, 2022

Conversation

kanadgupta
Copy link
Member

🧰 Changes

Per internal discussion, this adds env variable support for setting the host and hub config variables.

🧬 QA & Testing

Confirmed that the config.host value is updated properly when passing in the README_HOST env variable:

image

@kanadgupta kanadgupta added the enhancement New feature or request label Jul 15, 2022
rafegoldberg
rafegoldberg approved these changes Jul 15, 2022
View reviewed changes
Copy link

@rafegoldberg rafegoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coolshit-420.ninja

@kanadgupta kanadgupta merged commit 122ba5c into main Jul 15, 2022
@kanadgupta kanadgupta deleted the feat/config branch July 15, 2022 14:05
@r0hack r0hack mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

@domharrington domharrington domharrington approved these changes

@rafegoldberg rafegoldberg rafegoldberg approved these changes

@gratcliff gratcliff Awaiting requested review from gratcliff

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kanadgupta @erunion @domharrington @rafegoldberg