Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions secrets correction in documentation #470

Closed
paulcjh opened this issue Mar 8, 2022 · 2 comments · Fixed by #471
Closed

Github actions secrets correction in documentation #470

paulcjh opened this issue Mar 8, 2022 · 2 comments · Fixed by #471
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@paulcjh
Copy link

paulcjh commented Mar 8, 2022

Currently in the main sync docs here the method used for using github secrets doesn't work. It requires the addition of $ at the start to yield the secret:

Old

- uses: readmeio/rdme@RDME_VERSION
  with:
    rdme: openapi [path-to-file.json] --key={{ secrets.README_API_KEY }} --id={{ secrets.README_API_DEFINITION_ID }}

New

- uses: readmeio/rdme@RDME_VERSION
  with:
    rdme: openapi [path-to-file.json] --key=${{ secrets.README_API_KEY }} --id=${{ secrets.README_API_DEFINITION_ID }}
@kanadgupta kanadgupta added the documentation Improvements or additions to documentation label Mar 8, 2022
@kanadgupta kanadgupta added this to the v7 milestone Mar 8, 2022
@kanadgupta
Copy link
Member

kanadgupta commented Mar 8, 2022

Yikes, thanks for the catch @paulcjh! Fixed in #471 and the changes are now live: https://docs.readme.com/docs/rdme#example-using-github-secrets

@paulcjh
Copy link
Author

paulcjh commented Mar 24, 2022

Thanks! @kanadgupta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants