Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrading oas-normalize to resolve validation quirks #362

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Aug 26, 2021

🧰 Changes

  • Upgrades oas-normalize to the latest version to resolve a quirk with its .validate() method where it would run dereferencing before and during validation. Since .validate() only needs to validate that's all it does now.

🧬 QA & Testing

Though the oas-normalize change was a breaking change, our use of it here doesn't need to change assuming tests still pass.

📖 Release Notes

4.0.0 (2021-08-26)

🚨  Breaking change!

.validate() will no longer dereference schemas. If you need to dereference before or after validating, you shoudl use the .deref() method instead.

@erunion erunion added the dependencies Pull requests that update a dependency file label Aug 26, 2021
@erunion erunion requested a review from kanadgupta August 26, 2021 23:00
@kanadgupta
Copy link
Member

kanadgupta commented Aug 26, 2021

LGTM other than the snapshot updates! At least that means the changes worked 🤩

@erunion erunion merged commit 27ab077 into main Aug 26, 2021
@erunion erunion deleted the chore/update-oas-normalize branch August 26, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants