Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dedupe security schemes when plucking them out of an oas #222

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

erunion
Copy link
Member

@erunion erunion commented Jul 14, 2020

This resolves an issue with operation.prepareSecurity() where if an operation used the same security scheme multiples within an || security definition, it would be prepared multiple times, resulting in something that looks like the following within the API Explorer:

Screen Shot 2020-07-14 at 12 44 17 PM

With this fix, it'll now look like:

Screen Shot 2020-07-14 at 12 44 32 PM

@erunion erunion added the bug Something isn't working label Jul 14, 2020
Copy link
Member

@gratcliff gratcliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@erunion erunion merged commit acb9bf1 into master Jul 14, 2020
@erunion erunion deleted the fix/dedupe-securities branch July 14, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants