-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] PropertyBindingMixins.Bind crashes #2170
Comments
Hey @setallunder 👋, Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider contributing financially. https://opencollective.com/reactiveui
|
I'm also experiencing this. Android 9, Samsung SM-G892A. Same stack trace. |
I just started experiencing this after upgrading from ReactiveUI 9.16.6 to 10.5.1. |
Going to look into this on the weekend unless someone beats me to it. If someone else gets a pr in the mean time happy to take it. |
Thanks @glennawatson! FWIW, there's no runtime problem in our Xamarin.iOS or Xamarin.Forms apps, and the Xamarin.Forms app is targeted only for Android. It seems to be a problem unique to the Xamarin.Android runtime. Here are some truncated logs: |
So far, this only seems to happen when binding to a TextView. And if we use a OneWayBind (from ViewModel to View) the crash does not happen. So it seems that the problem originates from reacting to Android TextView changes. I don't know anything about the ReactiveUI code base, so take this diagnosis with a grain of salt... The very bottom of
And the logs seem to indicate that the crash is originating from within the Subscribe block, when Could it be that the tuple declaration is in some way contributing to the runtime reflection crash? |
@ajhuntsman We converted from Tuples to Value Tuples because of performance. It's odd that the java runtime would have an issue with it. |
So I looked into this a little more. Seems that the
|
We tracked down the bug and the location (actually to do with some changes with the Reflection.cs file), so hopefully can get a patch out in the next few days. |
Just to add more info to this issue: Looks like this exception also happens when binding to |
Any update or a quick workaround for this ? |
UpdateIt seems there is something about the reflection used to bind the properties that is causing this issue. We have a WIP pull request where @glennawatson and I have been doing various fixes trying to address this issue. We rolled back the v10 change and that did not seem to fix the problem, which we found odd. @arda-a A work around would be to just assign the values in the @ajhuntsman That was the correct place, it seems the reflection is more the culprit as I did a bit of changing around the |
I'm updating from ReactiveUI 9.20.1 to 11.1.6 and I'm encountering the same bug. |
We've passed this bug onto the Reactive Extensions team. See
dotnet/reactive#1129 to track it.
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Describe the bug
ReactiveUI.PropertyBindingMixins.Bind
throwsandroid.runtime.JavaProxyThrowable: System.Reflection.TargetParameterCountException: Parameter count mismatch.
Steps To Reproduce
ReactiveUI.PropertyBindingMixins.Bind
inside activity to bindTextView.Text
with ViewModel for example:Expected behavior
No crash
Stacktrace
Environment
The text was updated successfully, but these errors were encountered: