feat: move theming to core and pass theme to options #11707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11707 +/- ##
==========================================
+ Coverage 75.95% 75.96% +0.01%
==========================================
Files 207 207
Lines 5939 5942 +3
Branches 2301 2302 +1
==========================================
+ Hits 4511 4514 +3
Misses 1378 1378
Partials 50 50 ☔ View full report in Codecov by Sentry. |
satya164
force-pushed
the
@satya164/theming
branch
from
afb2be1 to
6693041
Compare
|
The Expo app for the example from this branch is ready! |
This moves theming logic to `@react-navigation/core`. So we can now pass the `theme` to the `options` and `screenOptions` callbacks. As `options` often specifies UI elements and styles, it's nice to have theme available there.
satya164
force-pushed
the
@satya164/theming
branch
from
6693041 to
2a6a011
Compare
osdnk
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves theming logic to
@react-navigation/core. So we can now pass thethemeto theoptionsandscreenOptionscallbacks. Asoptionsoften specifies UI elements and styles, it's nice to have theme available there.