fix: handle raw: true option to pass form submission values correctly (#733)

* test: make tests happy

* fix(resolver): handle `raw: true` option to pass form submission values correctly

Ensure that the `raw: true` option in the Resolver now correctly passes a copy of the form submission values, preventing data loss or inconsistencies.

* doc(effect): update readme

* doc(zod): update import example

Author: jorisre

README.md

@@ -119,7 +119,7 @@ TypeScript-first schema validation with static type inference
 ```tsx
 import { useForm } from 'react-hook-form';
 import { zodResolver } from '@hookform/resolvers/zod';
-import * as z from 'zod';
+import { z } from 'zod';
 
 const schema = z.object({
   name: z.string().min(1, { message: 'Required' }),
@@ -626,7 +626,7 @@ Universal adapter for schema validation, compatible with [any validation library
 ```typescript jsx
 import { useForm } from 'react-hook-form';
 import { typeschemaResolver } from '@hookform/resolvers/typeschema';
-import * as z from 'zod';
+import { z } from 'zod';
 
 // Use your favorite validation library
 const schema = z.object({
@@ -663,10 +663,10 @@ import { Schema } from 'effect';
 
 const schema = Schema.Struct({
   username: Schema.String.pipe(
-    Schema.nonEmpty({ message: () => 'username required' }),
+    Schema.nonEmptyString({ message: () => 'username required' }),
   ),
   password: Schema.String.pipe(
-    Schema.nonEmpty({ message: () => 'password required' }),
+    Schema.nonEmptyString({ message: () => 'password required' }),
   ),
 });
 

arktype/src/__tests__/Form.tsx

@@ -47,10 +47,10 @@ test("form's validation with arkType and TypeScript's integration", async () =>
   await user.click(screen.getByText(/submit/i));
 
   expect(
-    screen.getByText('username must be more than length 1 (was 0)'),
+    screen.getByText('username must be more than length 1'),
   ).toBeInTheDocument();
   expect(
-    screen.getByText('password must be more than length 1 (was 0)'),
+    screen.getByText('password must be more than length 1'),
   ).toBeInTheDocument();
   expect(handleSubmit).not.toHaveBeenCalled();
 });

arktype/src/arktype.ts

@@ -26,6 +26,6 @@ export const arktypeResolver: Resolver =
 
     return {
       errors: {} as FieldErrors,
-      values: resolverOptions.raw ? values : out,
+      values: resolverOptions.raw ? Object.assign({}, values) : out,
     };
   };

bun.lockb

@@ -25,7 +25,7 @@ describe('classValidatorResolver', () => {
 
   it('should return values as a raw object from classValidatorResolver when `rawValues` set to true', async () => {
     const result = await classValidatorResolver(Schema, undefined, {
-      rawValues: true,
+      raw: true,
     })(validData, undefined, {
       fields,
       shouldUseNativeValidation,

class-validator/src/__tests__/class-validator.ts

@@ -61,7 +61,7 @@ export const classValidatorResolver: Resolver =
     options.shouldUseNativeValidation && validateFieldsNatively({}, options);
 
     return {
-      values: resolverOptions.rawValues ? values : data,
+      values: resolverOptions.raw ? Object.assign({}, values) : data,
       errors: {},
     };
   };

class-validator/src/class-validator.ts

@@ -8,7 +8,7 @@ export type Resolver = <T extends { [_: string]: any }>(
     validator?: ValidatorOptions;
     transformer?: ClassTransformOptions;
   },
-  resolverOptions?: { mode?: 'async' | 'sync'; rawValues?: boolean },
+  resolverOptions?: { mode?: 'async' | 'sync'; raw?: boolean },
 ) => <TFieldValues extends FieldValues, TContext>(
   values: TFieldValues,
   context: TContext | undefined,

class-validator/src/types.ts

@@ -29,7 +29,7 @@ export const superstructResolver: Resolver =
     options.shouldUseNativeValidation && validateFieldsNatively({}, options);
 
     return {
-      values: resolverOptions.raw ? values : result[1],
+      values: resolverOptions.raw ? Object.assign({}, values) : result[1],
       errors: {},
     };
   };

superstruct/src/superstruct.ts

@@ -53,7 +53,9 @@ export const typeschemaResolver: Resolver =
     if (result.success) {
       return {
         errors: {} as FieldErrors,
-        values: resolverOptions.raw ? values : (result.data as any),
+        values: resolverOptions.raw
+          ? Object.assign({}, values)
+          : (result.data as any),
       };
     }
 

typeschema/src/typeschema.ts

@@ -130,7 +130,7 @@ describe('valibotResolver', () => {
     expect(result).toEqual({
       errors: {
         type: {
-          message: 'Invalid type: Expected "a" | "b" but received "c"',
+          message: 'Invalid type: Expected ("a" | "b") but received "c"',
           ref: undefined,
           type: 'variant',
         },

valibot/src/__tests__/valibot.ts

@@ -67,7 +67,9 @@ export const valibotResolver: Resolver =
 
     // Otherwise, return resolver result with values
     return {
-      values: resolverOptions.raw ? values : (result.output as FieldValues),
+      values: resolverOptions.raw
+        ? Object.assign({}, values)
+        : (result.output as FieldValues),
       errors: {},
     };
   };

valibot/src/valibot.ts

@@ -46,7 +46,7 @@ export const vineResolver: Resolver =
 
       return {
         errors: {} as FieldErrors,
-        values: resolverOptions.raw ? values : data,
+        values: resolverOptions.raw ? Object.assign({}, values) : data,
       };
     } catch (error: any) {
       if (error instanceof errors.E_VALIDATION_ERROR) {

vine/src/vine.ts

@@ -78,7 +78,7 @@ export function yupResolver<TFieldValues extends FieldValues>(
       options.shouldUseNativeValidation && validateFieldsNatively({}, options);
 
       return {
-        values: resolverOptions.raw ? values : result,
+        values: resolverOptions.raw ? Object.assign({}, values) : result,
         errors: {},
       };
     } catch (e: any) {

yup/src/yup.ts

@@ -68,7 +68,7 @@ export const zodResolver: Resolver =
 
       return {
         errors: {} as FieldErrors,
-        values: resolverOptions.raw ? values : data,
+        values: resolverOptions.raw ? Object.assign({}, values) : data,
       };
     } catch (error: any) {
       if (isZodError(error)) {