Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update timeout in provider #164

Closed
sozercan opened this issue Apr 13, 2022 · 4 comments
Closed

update timeout in provider #164

sozercan opened this issue Apr 13, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@sozercan
Copy link
Contributor

this is configured as 100s, should not be this high
https://github.com/deislabs/ratify/blob/ed76d1419a08490fa2d4ed05b7fc4a57376a5fee/charts/ratify/templates/provider.yaml#L7

@susanshi
Copy link
Collaborator

Hi @sozercan , is this is the timeout for ratify to respond to gatekeeper request, we can update this to 8s to align with the validating webhook timeout of 7s. Is 8s reasonable here?

@sozercan
Copy link
Contributor Author

@susanshi this is timeout for the provider. it should be less than the timeout of webhook so provider returns something back to gatekeeper instead of waiting for the webhook to timeout

@dtzar dtzar added this to the v1.0.0-beta milestone Jul 26, 2022
@dtzar
Copy link
Contributor

dtzar commented Aug 1, 2022

Related previous PR/Discussion #92

@dtzar dtzar added the enhancement New feature or request label Nov 3, 2022
@dtzar dtzar modified the milestones: v1.0.0-beta.1, v1.0.0-beta.2 Nov 3, 2022
@akashsinghal
Copy link
Collaborator

We have updated the timeout in provider to match the webhook timeout of 7 seconds configured. Other performance improvements will be tracked using #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants