Add stereo preview example #895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an example demonstrating the use of stride, where the stride is set to twice the image width to allow an image from a second camera to be copied into the empty space, creating a stereo image Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>
Add a test to check the stride is being set correctly when provided in the stream configuration Signed-off-by: William Vinnicombe <william.vinnicombe@raspberrypi.com>
|
On vc4 at least we could allow the selection API to set the compose rectangle to cover the part of the double sized buffer that the ISP is meant to write into. The same buffer could therefore be written by 2 instances of libcamera (one for each eye). The offset will need to be aligned based on the ISP constraints. I have no idea with regard how to pass that information through libcamera in order to request this though! |
|
@will-v-pi There was some kernel update required which is why we didn't merge this immediately, do we think that might all be sorted now? Perhaps it's worth rebasing and re-pushing...? |
|
Closing and re-opening just to re-run the tests. |
Merged
|
This has now been rebased and merged here: #1146 Sorry it took so long!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example demonstrating the use of stride, where the stride is set to twice the image width to allow an image from a second camera to be copied into the empty space, creating a stereo image