Skip to content

Commit

Permalink
fixup! irqchip: irq-bcm2712-mip: Support for 2712's MIP
Browse files Browse the repository at this point in the history
Use irq_domain_add_hierarchy so that the root pointer is initialised
correctly. Failure to do so leads to (at least) lockdep warnings when
they are enabled.

See: #5866

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
  • Loading branch information
pelwell committed Jan 18, 2024
1 parent f43fbd3 commit 217d588
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/irqchip/irq-bcm2712-mip.c
Original file line number Diff line number Diff line change
Expand Up @@ -209,16 +209,14 @@ static int mip_init_domains(struct mip_priv *priv,
return -ENXIO;
}

middle_domain = irq_domain_add_tree(NULL,
&mip_irq_domain_ops,
priv);
middle_domain = irq_domain_add_hierarchy(gic_domain, 0, 0, NULL,
&mip_irq_domain_ops,
priv);
if (!middle_domain) {
pr_err("Failed to create the MIP middle domain\n");
return -ENOMEM;
}

middle_domain->parent = gic_domain;

msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(node),
&mip_msi_domain_info,
middle_domain);
Expand Down

0 comments on commit 217d588

Please sign in to comment.