[release/v1.7] use sha256 for checksumming when k8s version >= 1.31.6 #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqiluo
approved these changes
Feb 21, 2025
HarrisonWAffel
approved these changes
Feb 21, 2025
|
@thatmidwesterncoder Could you also forward port this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl:dr; we use md5 for checksumming part of plans, so in order to minimize unnecessary cluster upgrades we decided to just gate the
getStringChecksum(string)function to require a kubernetes version and then use a better hashing algorithm over time. This way as time goes on the "insecure" hashing algorithm will not be used.