-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix slice init length #3695
Conversation
This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions. |
friengly ping |
This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions. |
friengly ping |
Closed and reopened, to retrigger CI. |
It seems that all CI has passed. |
hi @cuishuang , thank you for raising the fix! |
Of course. The new pr for the release/v1.7 branch. #3785 |
This reverts commit 1929342. Reverted to handle a release issue.
This reverts commit c6758c1. Re-applying the original commit after a release.
[release/v1.6] Reapply "fix: fix slice init length (#3695)"
The intention here should be to initialize a slice with a capacity of len(oldIPs) and len(newIPs) rather than initializing the length of this slice.
The only demo: https://go.dev/play/p/q1BcVCmvidW