Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix slice init length #3695

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

cuishuang
Copy link
Contributor

The intention here should be to initialize a slice with a capacity of len(oldIPs) and len(newIPs) rather than initializing the length of this slice.

The only demo: https://go.dev/play/p/q1BcVCmvidW

Copy link
Contributor

github-actions bot commented Dec 3, 2024

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

@cuishuang
Copy link
Contributor Author

friengly ping

Copy link
Contributor

github-actions bot commented Feb 2, 2025

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

@cuishuang
Copy link
Contributor Author

friengly ping

@mitulshah-suse
Copy link
Contributor

Closed and reopened, to retrigger CI.

@cuishuang
Copy link
Contributor Author

Closed and reopened, to retrigger CI.

It seems that all CI has passed.

@jiaqiluo jiaqiluo merged commit 1929342 into rancher:release/v1.6 Feb 7, 2025
11 of 16 checks passed
@jiaqiluo
Copy link
Member

jiaqiluo commented Feb 7, 2025

hi @cuishuang , thank you for raising the fix!
Could you raise another PR to cherry-pick the fix to the release/v1.7 branch?

@cuishuang
Copy link
Contributor Author

hi @cuishuang , thank you for raising the fix! Could you raise another PR to cherry-pick the fix to the release/v1.7 branch?

Of course. The new pr for the release/v1.7 branch. #3785

pedromfcarvalho added a commit to pedromfcarvalho/rke that referenced this pull request Feb 18, 2025
This reverts commit 1929342.

Reverted to handle a release issue.
pedromfcarvalho added a commit to pedromfcarvalho/rke that referenced this pull request Feb 19, 2025
This reverts commit c6758c1.

Re-applying the original commit after a release.
pedromfcarvalho added a commit that referenced this pull request Feb 19, 2025
[release/v1.6] Reapply "fix: fix slice init length (#3695)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants