Add ReadWriteOncePod support for NodePath volumes #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
reviewed
Jul 9, 2023
There was a problem hiding this comment.
LGTM. Can you help add a test in https://github.com/rancher/local-path-provisioner/tree/master/test
Signed-off-by: Tobi Nehrlich <tobi@anothertobi.io>
`ReadWriteOncePod` was added with v0.22.x. Signed-off-by: Tobi Nehrlich <tobi@anothertobi.io>
This explicitly allows provisioning of NodePath-backed volumes with access mode ReadWriteOncePod. SharedFileSystemPath already implicitly supported the access mode. Signed-off-by: Tobi Nehrlich <tobi@anothertobi.io>
|
Rebased and added a test. |
derekbit
approved these changes
Nov 18, 2023
coolguy1771
referenced
this pull request
in coolguy1771/home-ops
Nov 22, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [local-path-provisioner](https://github.com/rancher/local-path-provisioner) | patch | `v0.0.24` -> `v0.0.25` | --- ### Release Notes <details> <summary>rancher/local-path-provisioner (local-path-provisioner)</summary> ### [`v0.0.25`](https://github.com/rancher/local-path-provisioner/releases/tag/v0.0.25): Local Path Provisioner v0.0.25 [Compare Source](https://github.com/rancher/local-path-provisioner/compare/v0.0.24...v0.0.25) ##### What's Changed - feat - Node name annotation by [@​osherElm](https://github.com/osherElm) in [https://github.com/rancher/local-path-provisioner/pull/340](https://github.com/rancher/local-path-provisioner/pull/340) - Helm: add namespace by [@​sergelogvinov](https://github.com/sergelogvinov) in [https://github.com/rancher/local-path-provisioner/pull/325](https://github.com/rancher/local-path-provisioner/pull/325) - Add storageClass.volumeBindingMode value to helm chart by [@​anisimovdk](https://github.com/anisimovdk) in [https://github.com/rancher/local-path-provisioner/pull/347](https://github.com/rancher/local-path-provisioner/pull/347) - Helm: add pod annotation, securityContext blocks by [@​sergelogvinov](https://github.com/sergelogvinov) in [https://github.com/rancher/local-path-provisioner/pull/321](https://github.com/rancher/local-path-provisioner/pull/321) - Set default volume type of storage class from Helm chart by [@​nltimv](https://github.com/nltimv) in [https://github.com/rancher/local-path-provisioner/pull/357](https://github.com/rancher/local-path-provisioner/pull/357) - Constraint default RBAC permissions by [@​sbocinec](https://github.com/sbocinec) in [https://github.com/rancher/local-path-provisioner/pull/336](https://github.com/rancher/local-path-provisioner/pull/336) - Helm: add pod tolerations to the helper-pod by [@​sergelogvinov](https://github.com/sergelogvinov) in [https://github.com/rancher/local-path-provisioner/pull/322](https://github.com/rancher/local-path-provisioner/pull/322) - deployment: Adapt values to be quoted when installed in templates by [@​ardumont](https://github.com/ardumont) in [https://github.com/rancher/local-path-provisioner/pull/358](https://github.com/rancher/local-path-provisioner/pull/358) - Save the helper pod logs to the provisioner logs by [@​js185692](https://github.com/js185692) in [https://github.com/rancher/local-path-provisioner/pull/324](https://github.com/rancher/local-path-provisioner/pull/324) - Add ReadWriteOncePod support for NodePath volumes by [@​anothertobi](https://github.com/anothertobi) in [https://github.com/rancher/local-path-provisioner/pull/331](https://github.com/rancher/local-path-provisioner/pull/331) - feature: Add configuretion to run setup/teardown command in helper container instead of run with script by [@​name212](https://github.com/name212) in [https://github.com/rancher/local-path-provisioner/pull/360](https://github.com/rancher/local-path-provisioner/pull/360) - Helm: Add common labels value and update uninstall for helm 3 by [@​kevinzwang](https://github.com/kevinzwang) in [https://github.com/rancher/local-path-provisioner/pull/319](https://github.com/rancher/local-path-provisioner/pull/319) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy42MS40IiwidXBkYXRlZEluVmVyIjoiMzcuNjMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explicitly allows provisioning of NodePath-backed volumes with
access mode ReadWriteOncePod.
SharedFileSystemPath already implicitly supported the access mode.
Signed-off-by: Tobi Nehrlich tobi@anothertobi.io