DO-1920 / allow user specific config #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2023 11:50
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
ghost
marked this pull request as ready for review
balda-rdx
approved these changes
Oct 26, 2023
shambupujar
reviewed
Oct 31, 2023
| @@ -120,13 +121,19 @@ def config(args): | |||
|
|
|||
|
|
|||
| @dockercommand([ | |||
| argument("-a", "--autoapprove", help="Pass this option to run without any prompts. " | |||
| "Use this for automation purpose only", action="store_true"), | |||
| argument("-aue", "--advanceduserenvs", | |||
There was a problem hiding this comment.
Parameter advanced user doesn't seem right. As this is specific to extra config, probably extranodeconfig or additionalnodeconfig might be better name
shambupujar
reviewed
Oct 31, 2023
| @@ -9,6 +9,10 @@ services: | |||
| core: | |||
| cap_add: | |||
| - NET_ADMIN | |||
| {% if core_node.advanced_user_envs is defined and core_node.advanced_user_envs is not none %} | |||
| env_file: | |||
There was a problem hiding this comment.
Why not mount the file so that it gets picked up here https://github.com/radixdlt/babylon-node/blob/main/docker/build_scripts/config_radixdlt.sh#L15
That way, the additional config doesn't need a environment variable definition at docker level?
Or do you think this is better option and why?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.