Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO-1985: remove the docker dependency when running in systemd #100

Merged
merged 17 commits into from
Nov 13, 2023
Merged

DO-1985: remove the docker dependency when running in systemd #100

merged 17 commits into from
Nov 13, 2023

Conversation

balda-rdx
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

Test Results

53 tests  +3   47 ✔️ +3   8s ⏱️ -22s
  1 suites ±0     6 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c260325. ± Comparison against base commit 6a3ab0b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3845 2556 66% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
node-runner-cli/commands/systemdcommand.py 51% 🟢
node-runner-cli/setup/BaseSetup.py 49% 🟢
node-runner-cli/setup/DockerSetup.py 57% 🟢
node-runner-cli/setup/SystemDSetup.py 46% 🟢
node-runner-cli/tests/unit/test_systemd.py 90% 🟢
TOTAL 59% 🟢

updated for commit: c260325 by action🐍

@balda-rdx balda-rdx changed the title remove the docker dependency when running in systemd DO-1985: remove the docker dependency when running in systemd Nov 1, 2023
shambupujar
shambupujar requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@shambupujar shambupujar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes overall look good, however the hardcoding on the systemd keystore path might not work well with many existing node setup

@balda-rdx balda-rdx merged commit db0d15a into main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shambupujar shambupujar shambupujar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balda-rdx @shambupujar