Use RFC 7919 DH parameters #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasGasior1
commented
Feb 21, 2024
| 8W5vUsMWTfT7eTDp5OWIV7asfV9C1p9tGHdjzx1VA0AEh/VbpX4xzHpxNciG77Qx | ||
| iu1qHgEtnmgyqQdgCpGBMMRtx3j5ca0AOAkpmaMzy4t6Gh25PXFAADwqTs6p+Y0K | ||
| zAqCkc3OyX3Pjsm1Wn+IpGtNtahR9EGC4caKAH5eZV9q//////////8CAQI= | ||
| -----END DH PARAMETERS----- |
There was a problem hiding this comment.
|
Docker tags |
dhedey
approved these changes
Mar 19, 2024
marek-karwacki-rdx
approved these changes
Mar 19, 2024
shambupujar
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the default nginx configuration to use a standard ffdhe2048 group defined in RFC 7919 for its
ssl_dhparam. This removes the need to generate the parameters locally (see radixdlt/babylon-nodecli#111), while still allowing to use DHE. RFC 7919 is widely used, e.g. by Mozilla.This must be added manually because nginx doesn't provide defaults for
ssl_dhparam.