Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling from PYPI still resolves as 0.1.0 #692

Closed
rroodll opened this issue Feb 20, 2024 · 8 comments
Closed

Pulling from PYPI still resolves as 0.1.0 #692

rroodll opened this issue Feb 20, 2024 · 8 comments

Comments

@rroodll
Copy link

rroodll commented Feb 20, 2024

I've tried pulling the latest from pypi, even doing the normal

pip install qualtran

ends up pulling version 0.1.0 instead of 0.2.0

I'm not sure if this is simply a labeling problem on pypi or it is actually giving us the incorrect version.
I tried pulling the github code down as well and even though the version in _version.py =
image

it pip installs locally as 0.1.0

@mpharrigan
Copy link
Collaborator

the latest on pypi is indeed 0.2.0

https://pypi.org/project/qualtran/

Have you tried either

pip install -U qualtran

or

pip install qualtran==0.2.0

@rroodll
Copy link
Author

rroodll commented Feb 23, 2024

after some more testing and research, this appears to be a 10 year old known bug in pip. Apparently it has something to do with the pip installer taking a local cached version.

passing in the current version from pypi does indeed work. I had hoped to have our installer just take the latest, but it appears that may not always work.

OS thread:
https://stackoverflow.com/questions/14617136/why-is-pip-installing-an-old-version-of-my-package

@rroodll
Copy link
Author

rroodll commented Feb 23, 2024

just for brevity and in case anyone else trips across this...

the true issue was unmasked when I changed our install to tie it to qualtran==0.2.0

that uncovered that the qualtran==0.2.0 was requiring cirq-core's October build, but we were requiring the Nov build. A simple wind-back to match the versions fixed the problem.

image

@rroodll rroodll closed this as completed Feb 23, 2024
@mpharrigan
Copy link
Collaborator

sorry about that. I think after cirq 1.4 is released we won't be tied to a particular cirq version @tanujkhattar

@rroodll
Copy link
Author

rroodll commented Feb 23, 2024

no worries. Any idea when 1.4 is roughly scheduled?
I only ask because we already got a question about it when we pushed our last release in December. lol
No commitments expected, we told them "in a few months we'd remove the restriction"

@mpharrigan
Copy link
Collaborator

The reason why we bumped the pin was to pull in this bugfix pr

quantumlib/Cirq#6467

to fix this issue

#665

I think this PR introduced the problem: quantumlib/Cirq#6332

but I just installed cirq-core==1.3 and ran the qualtran tests against main and there weren't any errors, so maybe we can change the requirement to cirq-core>=1.3 @tanujkhattar what do you think

@tanujkhattar
Copy link
Collaborator

I think it's been a quarter since we did a Cirq release so we can go ahead and do that as well. Otherwise we can definitely do a patch release to get these changes in instead of depending on an older version of Cirq. cc @pavoljuhas

@pavoljuhas
Copy link
Contributor

@tanujkhattar - let us sync on Monday about what is the best option to do. (I am OOO today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants