Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DensityMatrixSimulator().simulate() return value type annotation #2413

Closed
mpharrigan opened this issue Oct 25, 2019 · 3 comments
Closed

DensityMatrixSimulator().simulate() return value type annotation #2413

mpharrigan opened this issue Oct 25, 2019 · 3 comments
Assignees
Labels
area/cleancode area/simulation complexity/low introduces/modifies 1-2 concepts, should take 1-2 days max for an advanced contributor kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@mpharrigan
Copy link
Collaborator

Should be DensityMatrixTrialResult. Due to inheritance, it is SimulationTrialResult leading to problems if you actually try to use it

#2308 (comment)

@Ashalynd
Copy link
Collaborator

Ashalynd commented Nov 6, 2019

Shouldn't there be some consistency? E.g. all simulate() methods should return SimulationTrialResult which then can be cast to the corresponding type. (Though it seems odd too)

@balopat balopat added area/cleancode complexity/low introduces/modifies 1-2 concepts, should take 1-2 days max for an advanced contributor kind/health For CI/testing/release process/refactoring/technical debt items area/simulation and removed difficulty: trivial labels Sep 15, 2020
@daxfohl
Copy link
Collaborator

daxfohl commented Jun 9, 2021

@balopat This has been fixed for a while and can be closed.

@mpharrigan
Copy link
Collaborator Author

Fixed by #3818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cleancode area/simulation complexity/low introduces/modifies 1-2 concepts, should take 1-2 days max for an advanced contributor kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Development

No branches or pull requests

5 participants