Skip to content

Commit bae56f5

Browse files
authored
Merge pull request #294 from marcwrobel/fix-typos
fix typos in documentations
2 parents 05c0b0a + 24788ac commit bae56f5

File tree

30 files changed

+49
-52
lines changed

30 files changed

+49
-52
lines changed

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@ for your work if appropriate. It usually is.
4040
4. All commits must have signed off by the contributor attesting to
4141
[Developer Certificate of Origin
4242
(DCO)](https://developercertificate.org/). Commits without sign off
43-
will be automatically rejected by the [DCO github
43+
will be automatically rejected by the [DCO GitHub
4444
check](https://probot.github.io/apps/dco/) application.
4545

46-
5. Push your changes to your fork/branch in github. Don't push it to
46+
5. Push your changes to your fork/branch in GitHub. Don't push it to
4747
your master! If you do it will make it harder to submit new changes
4848
later.
4949

50-
6. Submit a pull request to SLF4J from your commit page on github.
50+
6. Submit a pull request to SLF4J from your commit page on GitHub.
5151

5252
7. Did we mention that you will be asked to link your pull request
5353
with a Jira ticket?

integration/osgi-build.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666

6767

6868
<!-- for some reason if mvn is invoked from the parent directory, junit gets
69-
invoked from the parent dir, which messes up theses tests. Hence, the
69+
invoked from the parent dir, which messes up these tests. Hence, the
7070
fork="yes" dir="${basedir}" -->
7171

7272
<!--
@@ -107,4 +107,4 @@
107107
</junit>
108108
</target>
109109

110-
</project>
110+
</project>

jcl-over-slf4j/src/main/java/org/apache/commons/logging/impl/SLF4JLogFactory.java

+5-7
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,10 @@ public Log getInstance(String name) throws LogConfigurationException {
173173
public void release() {
174174
// This method is never called by jcl-over-slf4j classes. However,
175175
// in certain deployment scenarios, in particular if jcl-over-slf4j.jar
176-
// is
177-
// in the the web-app class loader and the official commons-logging.jar is
178-
// deployed in some parent class loader (e.g. commons/lib), then it is
179-
// possible
180-
// for the parent class loader to mask the classes shipping in
181-
// jcl-over-slf4j.jar.
176+
// is in the web-app class loader and the official commons-logging.jar
177+
// is deployed in some parent class loader (e.g. commons/lib), then it
178+
// is possible for the parent class loader to mask the classes shipping
179+
// in jcl-over-slf4j.jar.
182180
System.out.println("WARN: The method " + SLF4JLogFactory.class + "#release() was invoked.");
183181
System.out.println("WARN: Please see http://www.slf4j.org/codes.html#release for an explanation.");
184182
System.out.flush();
@@ -216,4 +214,4 @@ public void setAttribute(String name, Object value) {
216214
}
217215

218216
}
219-
}
217+
}

jcl-over-slf4j/src/main/java/org/apache/commons/logging/package.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ <h3>Overview</h3>
3131
<p>As the original JCL version 1.0.4, the present version supports
3232
various logging APIs. It differs from the original in implementation
3333
but not the public API. This implementation uses SLF4J under the
34-
covers. As as such, all the logging systems that SLF4J supports,
34+
covers. As such, all the logging systems that SLF4J supports,
3535
e.g. NOP, Simple, JDK14, nlog4j are supported by this version of JCL.
3636
</p>
3737

jul-to-slf4j/src/main/java/org/slf4j/bridge/SLF4JBridgeHandler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,12 @@
7979
* SLF4J translation can seriously increase the cost of disabled logging
8080
* statements (60 fold or 6000% increase) and measurably impact the performance of enabled log
8181
* statements (20% overall increase).</b> Please note that as of logback-version 0.9.25,
82-
* it is possible to completely eliminate the 60 fold translation overhead for disabled
82+
* it is possible to completely eliminate the 60-fold translation overhead for disabled
8383
* log statements with the help of <a href="http://logback.qos.ch/manual/configuration.html#LevelChangePropagator">LevelChangePropagator</a>.
8484
*
8585
*
8686
* <p>If you are concerned about application performance, then use of <code>SLF4JBridgeHandler</code>
87-
* is appropriate only if any one the following two conditions is true:
87+
* is appropriate only if any of the following conditions is true:
8888
* <ol>
8989
* <li>few j.u.l. logging statements are in play</li>
9090
* <li>LevelChangePropagator has been installed</li>
@@ -93,7 +93,7 @@
9393
* <h2>As a Java 9/Jigsaw module</h2>
9494
*
9595
* <p>Given that <b>to</b> is a reserved keyword under Java 9 within module productions,
96-
* the MAFIFEST.MF file in <em>jul-to-slf4j.jar</em> declares <b>jul_to_slf4j</b> as
96+
* the MANIFEST.MF file in <em>jul-to-slf4j.jar</em> declares <b>jul_to_slf4j</b> as
9797
* its Automatic Module Name. Thus, if your application is Jigsaw modularized, the requires
9898
* statement in your <em>module-info.java</em> needs to be <b>jul_to_slf4j</b>
9999
* (note the two underscores).

log4j-over-slf4j/compatibility/build.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
<!-- ================================================================= -->
4040
<target name="usage">
4141
<echo>
42-
These are some of the targets supported by this ANT build scpript:
42+
These are some of the targets supported by this ANT build script:
4343

4444
all - run all available tests
4545
refresh - copy required jar files to the lib directory

log4j-over-slf4j/compatibility/readme.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ that uses either log4j 1.2.x, or log4j 1.3.x.
55

66
In the same directory is a build.xml file that uses ant to
77
compile the test cases with the corresponding log4j version,
8-
and to runs these tests without log4j in the classpath but with
8+
and to run these tests without log4j in the classpath but with
99
logback jars instead.
1010

1111
To run the tests, one must have ant installed. Issuing the following command,

log4j-over-slf4j/src/main/java/org/apache/log4j/Appender.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public interface Appender {
114114
* Configurators call this method to determine if the appender
115115
* requires a layout. If this method returns <code>true</code>,
116116
* meaning that layout is required, then the configurator will
117-
* configure an layout using the configuration information at its
117+
* configure a layout using the configuration information at its
118118
* disposal. If this method returns <code>false</code>, meaning that
119119
* a layout is not required, then layout configuration will be
120120
* skipped even if there is available layout configuration

log4j-over-slf4j/src/main/java/org/apache/log4j/Priority.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ public static Priority toPriority(int val) {
187187
*
188188
* @param val an integer value
189189
* @param defaultPriority a default priority value
190-
* @return correspoding Priority value
190+
* @return corresponding Priority value
191191
*/
192192
@Deprecated
193193
public static Priority toPriority(int val, Priority defaultPriority) {
@@ -204,4 +204,4 @@ public static Priority toPriority(int val, Priority defaultPriority) {
204204
public static Priority toPriority(String sArg, Priority defaultPriority) {
205205
return Level.toLevel(sArg, (Level) defaultPriority);
206206
}
207-
}
207+
}

log4j-over-slf4j/src/main/java/org/apache/log4j/PropertyConfigurator.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import org.apache.log4j.spi.LoggerRepository;
2424

2525
/**
26-
* An nop implementation of PropertyConfigurator.
26+
* A no-op implementation of PropertyConfigurator.
2727
*/
2828
public class PropertyConfigurator implements Configurator {
2929
public static void configure(Properties properties) {

log4j-over-slf4j/src/main/java/org/apache/log4j/helpers/LogLog.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<b>log4j.configDebug</b> variable.
2626
2727
<p>All log4j internal debug calls go to <code>System.out</code>
28-
where as internal error messages are sent to
28+
whereas internal error messages are sent to
2929
<code>System.err</code>. All internal messages are prepended with
3030
the string "log4j: ".
3131
@@ -40,7 +40,7 @@ public class LogLog {
4040
4141
<p> The value of this string is <b>log4j.debug</b>.
4242
43-
<p>Note that the search for all option names is case sensitive. */
43+
<p>Note that the search for all option names is case-sensitive. */
4444
public static final String DEBUG_KEY = "log4j.debug";
4545

4646
/**
@@ -49,7 +49,7 @@ public class LogLog {
4949
5050
<p> The value of this string is <b>log4j.configDebug</b>.
5151
52-
<p>Note that the search for all option names is case sensitive.
52+
<p>Note that the search for all option names is case-sensitive.
5353
5454
@deprecated Use {@link #DEBUG_KEY} instead.
5555
*/

log4j-over-slf4j/src/main/java/org/apache/log4j/spi/LoggerFactory.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
/**
2222
2323
Implement this interface to create new instances of Logger or
24-
a sub-class of Logger.
24+
a subclass of Logger.
2525
2626
<p>See <code>examples/subclass/MyLogger.java</code> for an example.
2727

slf4j-api/src/main/java/org/slf4j/Logger.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383
public interface Logger {
8484

8585
/**
86-
* Case insensitive String constant used to retrieve the name of the root logger.
86+
* Case-insensitive String constant used to retrieve the name of the root logger.
8787
*
8888
* @since 1.3
8989
*/
@@ -510,7 +510,8 @@ default public LoggingEventBuilder atDebug() {
510510
* data is also taken into consideration.
511511
*
512512
* @param marker The marker data to take into consideration
513-
* @return true if this logger is warn enabled, false otherwise
513+
* @return true if this Logger is enabled for the INFO level,
514+
* false otherwise.
514515
*/
515516
public boolean isInfoEnabled(Marker marker);
516517

slf4j-api/src/main/java/org/slf4j/LoggerFactory.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ public static Logger getLogger(String name) {
363363
* using the statically bound {@link ILoggerFactory} instance.
364364
*
365365
* <p>
366-
* In case the the <code>clazz</code> parameter differs from the name of the
366+
* In case the <code>clazz</code> parameter differs from the name of the
367367
* caller as computed internally by SLF4J, a logger name mismatch warning
368368
* will be printed but only if the
369369
* <code>slf4j.detectLoggerNameMismatch</code> system property is set to

slf4j-api/src/main/java/org/slf4j/LoggerFactoryFriend.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
/**
2828
* All methods in this class are reserved for internal use, for testing purposes.
2929
*
30-
* <p>They can can be modified, renamed or removed at any time without notice.
30+
* <p>They can be modified, renamed or removed at any time without notice.
3131
*
3232
* <p>You are strongly discouraged calling any of the methods of this class.
3333
*

slf4j-api/src/main/java/org/slf4j/helpers/BasicMDCAdapter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public String get(String key) {
9292
}
9393

9494
/**
95-
* Remove the the context identified by the <code>key</code> parameter.
95+
* Remove the context identified by the <code>key</code> parameter.
9696
*/
9797
public void remove(String key) {
9898
Map<String, String> map = inheritableThreadLocalMap.get();

slf4j-api/src/main/java/org/slf4j/helpers/MessageFormatter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
* will return the string "File name is C:\file.zip".
8282
*
8383
* <p>
84-
* The formatting conventions are different than those of {@link MessageFormat}
84+
* The formatting conventions are different from those of {@link MessageFormat}
8585
* which ships with the Java platform. This is justified by the fact that
8686
* SLF4J's implementation is 10 times faster than that of {@link MessageFormat}.
8787
* This local performance difference is both measurable and significant in the

slf4j-api/src/main/java/org/slf4j/helpers/NOPLoggerFactory.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import org.slf4j.Logger;
2929

3030
/**
31-
* NOPLoggerFactory is an trivial implementation of {@link
31+
* NOPLoggerFactory is a trivial implementation of {@link
3232
* ILoggerFactory} which always returns the unique instance of
3333
* NOPLogger.
3434
*

slf4j-api/src/main/java/org/slf4j/helpers/NormalizedParameters.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import org.slf4j.event.LoggingEvent;
44

55
/**
6-
* Holds normalized calling call parameters.
6+
* Holds normalized call parameters.
77
*
88
* Includes utility methods such as {@link #normalize(String, Object[], Throwable)} to help the normalization of parameters.
99
*

slf4j-api/src/main/java/org/slf4j/spi/MDCAdapter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public interface MDCAdapter {
5656
public String get(String key);
5757

5858
/**
59-
* Remove the the context identified by the <code>key</code> parameter.
59+
* Remove the context identified by the <code>key</code> parameter.
6060
* The <code>key</code> parameter cannot be null.
6161
*
6262
* <p>

slf4j-api/src/test/java/org/slf4j/helpers/StringPrintStream.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,11 @@
3030
import java.util.List;
3131

3232
/**
33-
*
34-
* Copied from org.slfj.helpers.
33+
* Copied from org.slfj.helpers.
3534
*
36-
* Currently it is not possible to use test-jar from tests running on the module-path.
35+
* Currently it is not possible to use test-jar from tests running on the module-path.
3736
*
3837
* @author ceki
39-
*
4038
*/
4139
public class StringPrintStream extends PrintStream {
4240

@@ -73,4 +71,4 @@ public void println(Object o) {
7371
other.println(o);
7472
stringList.add(o.toString());
7573
}
76-
}
74+
}

slf4j-api/src/test/java/org/slf4j/helpers/SubstitutableLoggerTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
*/
4646
public class SubstitutableLoggerTest {
4747

48-
// NOTE: previous implementations of this class performed a hand crafted conversion of
48+
// NOTE: previous implementations of this class performed a handcrafted conversion of
4949
// a method to a string. In this implementation we just invoke method.toString().
5050

5151
// WARNING: if you need to add an excluded method to have tests pass, ask yourself whether you

slf4j-ext/src/main/java/org/slf4j/instrumentation/JavassistHelper.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public class JavassistHelper {
4141

4242
/**
4343
* Create a javassist source snippet which either is empty (for anything
44-
* which does not return a value) or a explanatory text around the $_
44+
* which does not return a value) or an explanatory text around the $_
4545
* javassist return value variable.
4646
*
4747
* @param method

slf4j-ext/src/main/java/org/slf4j/instrumentation/package.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<body>
1010
<p>Java instrumentation routines for SLF4J.</p>
1111

12-
<p>Byte code instrumentation is an way to change behaviour of java
12+
<p>Byte code instrumentation is a way to change behaviour of java
1313
classes at <i>load time</i>. This is done in-between the original byte
1414
codes are retrieved and the class object is constructed by the class
1515
loader. Currently this depends on the javassist library from JBoss

slf4j-jdk-platform-logging/src/main/java/org/slf4j/jdk/platform/logging/SLF4JPlatformLogger.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public void log(Level jplLevel, ResourceBundle bundle, String format, Object...
105105
}
106106

107107
/**
108-
* Single point of processing taking all possible paramets.
108+
* Single point of processing taking all possible parameters.
109109
*
110110
* @param jplLevel
111111
* @param bundle

slf4j-migrator/src/main/java/org/slf4j/migrator/helper/Abbreviator.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public String abbreviate(String filename) {
4444

4545
int firstIndex = filename.indexOf(folderSeparator, invariantPrefixLength);
4646
if (firstIndex == -1) {
47-
// we cant't process this string
47+
// we can't process this string
4848
return filename;
4949
}
5050
StringBuilder buf = new StringBuilder(desiredLength);

slf4j-migrator/src/main/java/org/slf4j/migrator/internal/MigratorFrame.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ private void createComponents() {
128128
*/
129129
private void constrainAll() {
130130

131-
// contrain migration label
131+
// constraints migration label
132132
layoutManager.putConstraint(SpringLayout.WEST, migrationLabel, BASIC_PADDING, SpringLayout.EAST, this);
133133

134134
layoutManager.putConstraint(SpringLayout.NORTH, migrationLabel, BASIC_PADDING, SpringLayout.NORTH, this);

slf4j-migrator/src/test/java/org/slf4j/migrator/AternativeApproach.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
public class AternativeApproach extends TestCase {
3535

3636
/**
37-
* In this test we see that we cans use more simple Pattern to do the
37+
* In this test we see that we can use more simple Pattern to do the
3838
* conversion
3939
*
4040
*/

slf4j-migrator/src/test/java/org/slf4j/migrator/line/TrivialMatcher.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,15 @@ public TrivialMatcher() {
4141
// simple rule no capturing group is defined, we use default capturing group which is group zero
4242
SingleConversionRule cr = new SingleConversionRule(Pattern.compile("import org.slf4j.converter"), "simple replacement with an unique capturing group");
4343

44-
// we define 4 differents capturing groups
44+
// we define 4 different capturing groups
4545
MultiGroupConversionRule cr1 = new MultiGroupConversionRule(Pattern.compile("(first group)( second group)( third group)( 4th group)"));
4646
// group zero is ignored during treatment
4747
// replacement for the first
4848
cr1.addReplacement(1, "1st group");
49-
// no replacement for the second group it will remains the same
49+
// no replacement for the second group it will remain the same
5050
// empty string for the third group it will be deleted
5151
cr1.addReplacement(3, "");
52-
// no replacement for the third group it will remains the same
52+
// no replacement for the third group it will remain the same
5353

5454
conversionRuleList = new ArrayList<>();
5555
conversionRuleList.add(cr);
@@ -60,4 +60,4 @@ public Iterator<ConversionRule> iterator() {
6060
return conversionRuleList.iterator();
6161
}
6262

63-
}
63+
}

slf4j-simple/src/test/java/org/slf4j/simple/multiThreadedExecution/MultithereadedExecutionTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
import org.slf4j.LoggerFactory;
3434

3535
/**
36-
* Tests that output in multi-threaded environments is not mingled.
36+
* Tests that output in multithreaded environments is not mingled.
3737
*
3838
* See also https://jira.qos.ch/browse/SLF4J-515
3939
*/

0 commit comments

Comments
 (0)