Nested control aka too many return statements

Author: noahd1

qlty-cli/tests/lang/csharp/basic.in/NestedControl.cs

@@ -0,0 +1,62 @@
+using System;
+
+public class Main
+{
+    public static void NotNested(string foo, string bar)
+    {
+        if ((foo == "cat" && bar == "dog") || (foo == "dog" && bar == "cat"))
+        {
+            Console.WriteLine("Got a cat and a dog!");
+        }
+        else
+        {
+            Console.WriteLine("Got nothing");
+        }
+    }
+
+    public static void F0(bool bar, bool baz, bool qux, bool quux)
+    {
+        if (bar)
+        {
+            if (baz)
+            {
+                if (qux)
+                {
+                    if (quux)
+                    {
+                        Console.WriteLine("Not deeply nested enough!");
+                    }
+                }
+            }
+        }
+    }
+
+    public static string F2(int foo)
+    {
+        switch (foo)
+        {
+            case 1:
+                return "bar1";
+            case 2:
+                return "bar2";
+            case 3:
+                return "bar3";
+            case 4:
+                return "bar4";
+            case 5:
+                return "bar5";
+            case 6:
+                return "bar6";
+            case 7:
+                return "bar7";
+            case 8:
+                return "bar8";
+            case 9:
+                return "bar9";
+            case 10:
+                return "bar10";
+            default:
+                throw new ArgumentException("Invalid foo value");
+        }
+    }
+}

qlty-cli/tests/lang/csharp/basic.stdout

@@ -2,7 +2,7 @@
   "metadata": {
     "buildId": "[..]",
     "result": "ANALYSIS_RESULT_SUCCESS",
-    "filesAnalyzed": 5,
+    "filesAnalyzed": 6,
     "startTime": "[..]",
     "finishTime": "[..]",
     "commitMessage": "initial/n",
@@ -240,6 +240,34 @@
         }
       },
       "mode": "MODE_BLOCK"
+    },
+    {
+      "buildId": "[..]",
+      "analyzedAt": "[..]",
+      "tool": "qlty",
+      "driver": "structure",
+      "ruleKey": "return-statements",
+      "message": "Function with many returns (count = 10): F2",
+      "level": "LEVEL_MEDIUM",
+      "language": "LANGUAGE_C_SHARP",
+      "category": "CATEGORY_STRUCTURE",
+      "snippet": "public static string F2(int foo)/n    {/n        switch (foo)/n        {/n            case 1:/n                return /"bar1/";/n            case 2:/n                return /"bar2/";/n            case 3:/n                return /"bar3/";/n            case 4:/n                return /"bar4/";/n            case 5:/n                return /"bar5/";/n            case 6:/n                return /"bar6/";/n            case 7:/n                return /"bar7/";/n            case 8:/n                return /"bar8/";/n            case 9:/n                return /"bar9/";/n            case 10:/n                return /"bar10/";/n            default:/n                throw new ArgumentException(/"Invalid foo value/");/n        }/n    }",
+      "snippetWithContext": "                {/n                    if (quux)/n                    {/n                        Console.WriteLine(/"Not deeply nested enough!/");/n                    }/n                }/n            }/n        }/n    }/n/n    public static string F2(int foo)/n    {/n        switch (foo)/n        {/n            case 1:/n                return /"bar1/";/n            case 2:/n                return /"bar2/";/n            case 3:/n                return /"bar3/";/n            case 4:/n                return /"bar4/";/n            case 5:/n                return /"bar5/";/n            case 6:/n                return /"bar6/";/n            case 7:/n                return /"bar7/";/n            case 8:/n                return /"bar8/";/n            case 9:/n                return /"bar9/";/n            case 10:/n                return /"bar10/";/n            default:/n                throw new ArgumentException(/"Invalid foo value/");/n        }/n    }/n}",
+      "effortMinutes": 35,
+      "value": 10,
+      "valueDelta": 4,
+      "location": {
+        "path": "NestedControl.cs",
+        "range": {
+          "startLine": 34,
+          "startColumn": 5,
+          "endLine": 61,
+          "endColumn": 6,
+          "startByte": 714,
+          "endByte": 1398
+        }
+      },
+      "mode": "MODE_BLOCK"
     }
   ],
   "stats": [
@@ -342,6 +370,26 @@
       "complexity": 1,
       "cyclomatic": 3,
       "lcom4": 0
+    },
+    {
+      "buildId": "[..]",
+      "analyzedAt": "[..]",
+      "name": "NestedControl.cs",
+      "fullyQualifiedName": "NestedControl.cs",
+      "path": "NestedControl.cs",
+      "kind": "COMPONENT_TYPE_FILE",
+      "language": "LANGUAGE_C_SHARP",
+      "files": 1,
+      "classes": 1,
+      "functions": 3,
+      "fields": 0,
+      "lines": 62,
+      "codeLines": 48,
+      "commentLines": 0,
+      "blankLines": 14,
+      "complexity": 15,
+      "cyclomatic": 24,
+      "lcom4": 0
     }
   ]
 }