Skip to content

Update temp_enclave.json #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update temp_enclave.json #68

wants to merge 1 commit into from

Conversation

prakrit55
Copy link

The names of the csv files have been added from the corresponding yaml files : )

Description

feat(service): automate csv assignment inside enclave.json

Closes: #45

Describe the changes you've made

CSVs have been mentioned in the enclave.json in the file section.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • Does this code have any breaking changes?
  • Does this code have any yaml schema changes?

@prakrit55
Update temp_enclave.json
b3cd9c4 
The names of the csv files have been added from the corresponding yaml files : )
@prakrit55
Copy link
Author

hello @qascade, need your review on this pr.

@qascade
Copy link
Owner

qascade commented Jun 9, 2023

The PR is incomplete. This is not automation just hardcoding of the csv names. The branch naming and the PR title needs to be according to the commit conventions. Please create a new draft PR. Understand the Project workflow and start coding once you have clear understanding of what to do next. Get a periodic review of the PR for better collaboration and learning.

@qascade qascade closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(service): automate csv assignment inside enclave.json
2 participants
@prakrit55 @qascade