Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch created initially with no new commits #280

Closed
edmorley opened this issue Mar 8, 2018 · 5 comments
Closed

Branch created initially with no new commits #280

edmorley opened this issue Mar 8, 2018 · 5 comments

Comments

@edmorley
Copy link

edmorley commented Mar 8, 2018

Hi!

It seems that pyup first creates and pushes a new branch that's equal to master, and then only after pushes changes to it. This causes Travis to trigger jobs on the first push, even though it doesn't yet have changes.

For example:

mozilla/treeherder/pull/3317
-> https://screenshots.firefox.com/9mQlhzMxPjcStcDg/travis-ci.org

mozilla/treeherder/pull/3321
-> https://screenshots.firefox.com/gBzUSwfM8uyIS60a/travis-ci.org

Please can pyup only push once, with the actual commits?

@jayfk
Copy link
Contributor

jayfk commented Mar 8, 2018

Haven't found a way to do this, yet. The bot is using the GitHub API to create the branch: https://github.com/pyupio/pyup/blob/master/pyup/providers/github.py#L116

Any idea how to do this without pushing the branch?

@edmorley
Copy link
Author

Could the commits be pushed before creating the ref?
If not perhaps a feature request could be filed against the github NPM package for a way to handle this?

Alternatively perhaps an NPM package for interacting with github using the git protocols might work?

@jayfk
Copy link
Contributor

jayfk commented Mar 29, 2018

This is all Python code on PyPi, no NPM involved :)

While going over GitHubs API docs I wasn't able to find an obvious way to do this. Going to contact support next.

@edmorley
Copy link
Author

edmorley commented Apr 3, 2018

This is all Python code on PyPi, no NPM involved :)

Sorry I've been filing a number of issues against https://github.com/renovateapp/renovate recently; crossed mental streams :-)

@rafaelpivato
Copy link
Contributor

Duplicated by #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants