-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The public v2 utils like query_size
or query_chw
are untested
#7785
Comments
@NicolasHug can I prod this up in priority? I've started working with v2 transforms and I need these functions to implement custom transforms that I can combine with the builtin ones... I really don't like having imports from _utils, _geometry, etc in my modules. |
Hi @rwightman , just to make sure I understand, you need those to be publicly available from |
@NicolasHug yes, they're needed to make custom v2 transforms that can handle flat inputs in the _get_params |
OK, sounds good. I exposed anything you might need in #8670. Since it's fairly low risk, I'll try to cherry-pick the PR to the release branch so that it's available for you in 0.20 (planned for later this month). Looking forward to seeing how you use the v2 transforms! LMK if there's anything I can help with. |
If we're going to expose them as public, we need unit tests for them.
The text was updated successfully, but these errors were encountered: