Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The public v2 utils like query_size or query_chw are untested #7785

Closed
NicolasHug opened this issue Aug 1, 2023 · 4 comments
Closed

The public v2 utils like query_size or query_chw are untested #7785

NicolasHug opened this issue Aug 1, 2023 · 4 comments

Comments

@NicolasHug
Copy link
Member

If we're going to expose them as public, we need unit tests for them.

@rwightman
Copy link
Contributor

@NicolasHug can I prod this up in priority? I've started working with v2 transforms and I need these functions to implement custom transforms that I can combine with the builtin ones... I really don't like having imports from _utils, _geometry, etc in my modules.

@NicolasHug
Copy link
Member Author

Hi @rwightman , just to make sure I understand, you need those to be publicly available from torchvision.transforms.v2?

@rwightman
Copy link
Contributor

@NicolasHug yes, they're needed to make custom v2 transforms that can handle flat inputs in the _get_params

@NicolasHug
Copy link
Member Author

OK, sounds good. I exposed anything you might need in #8670.

Since it's fairly low risk, I'll try to cherry-pick the PR to the release branch so that it's available for you in 0.20 (planned for later this month).

Looking forward to seeing how you use the v2 transforms! LMK if there's anything I can help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants