Fixed VideoRecorder crash when passing fps (#2827)

Author: AlexandreBrown

test/test_transforms.py

@@ -131,6 +131,7 @@
 from torchrl.envs.utils import check_env_specs, MarlGroupMapType, step_mdp
 from torchrl.modules import GRUModule, LSTMModule, MLP, ProbabilisticActor, TanhNormal
 from torchrl.modules.utils import get_primers_from_module
+from torchrl.record.recorder import VideoRecorder
 
 if os.getenv("PYTORCH_TEST_FBCODE"):
     from pytorch.rl.test._utils_internal import (  # noqa
@@ -13978,6 +13979,14 @@ def test_transform_inverse(self):
         raise pytest.skip("Tested elsewhere")
 
 
+class TestVideoRecorder:
+    # TODO: add more tests
+    def test_can_init_with_fps(self):
+        recorder = VideoRecorder(None, None, fps=30)
+
+        assert recorder is not None
+
+
 if __name__ == "__main__":
     args, unknown = argparse.ArgumentParser().parse_known_args()
     pytest.main([__file__, "--capture", "no", "--exitfirst"] + unknown)

torchrl/record/recorder.py

@@ -121,7 +121,7 @@ def __init__(
         video_kwargs = {}
         video_kwargs.update(kwargs)
         if fps is not None:
-            self.video_kwargs["fps"] = fps
+            video_kwargs["fps"] = fps
         self.video_kwargs = video_kwargs
         self.iter = 0
         self.skip = skip