protobuf: Prevent namespace package google from having a py.typed file at root #11261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le at root Short-term fix for #11254 (see discussion in the issue)
|
Let's hold off for now as stub_uploader should be fairly easy to fix. |
|
Good to hear. |
|
typeshed-internal/stub_uploader#122 should fix this issue. |
|
@srittau Since you quickly worked on a proper solution, I'll just close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short-term fix for #11254 (see discussion in the issue)
Long story short, assuming I got everything right: Spec says that namespace stubs-only packages should either not have a
py.typedmarker (which is already do for complete stubs) or that it should be in the submodules, not at root (we add apy.typedfile at root for partial stubs).mypy gets tripped up by the presence of the file. And it is not mypy's fault as it's within spec. This could be improved in stub_uploader. But the short term fix is simply to not generate a partial
py.typedmarker file for this stub at all.