-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stubs for pyvmomi (not until November 2023) #10149
Comments
Just for information, I tried the upstream type hints and they are not usable yet. With the initial pyvmomi release shipping type stubs (8.0.1.0), there are syntax errors in a few of the files, preventing their use completely with mypy (vmware/pyvmomi#1015), and beyond that it looks like there will be other issues as well. I'm sure the upstream stubs will improve over time, just need to wait some more. November deadline seems reasonable. The upside is that upstream type stubs look like they're autogenerated and very extensive, they cover all of the API surface, not just a few object types like |
Ah, thanks for letting us know. If the upstream type hints are completely unusable, maybe it would be better to revert #10148 for now. (With the stubs marked as obsolete, the description on PyPI tells users not to use |
Okay, for now we've reverted marking the stubs as obsolete. We can mark |
With the latest pyvmomi version 8.0.1.0.1 (May 25), the upstream type stubs work well with mypy for my use cases. PyCharm still struggles with upstream types, but I have not investigated that in detail. |
"Upstream types don't work perfectly with all type checkers" feels like it falls into the category of "the stubs are somewhat buggy" rather than "the stubs are fundamentally broken". So I'd vote for marking |
Now marked as obsolete since 8.0.1.0.1: 2ec6ba9 |
#10148
The text was updated successfully, but these errors were encountered: