Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stubs for pyvmomi (not until November 2023) #10149

Closed
hauntsaninja opened this issue May 6, 2023 · 6 comments · Fixed by #10957
Closed

Remove stubs for pyvmomi (not until November 2023) #10149

hauntsaninja opened this issue May 6, 2023 · 6 comments · Fixed by #10957
Labels
stubs: removal Pending removal of third-party distributions

Comments

@hauntsaninja
Copy link
Collaborator

#10148

@AlexWaygood AlexWaygood added the stubs: removal Pending removal of third-party distributions label May 6, 2023
@intgr
Copy link
Contributor

intgr commented May 10, 2023

Just for information, I tried the upstream type hints and they are not usable yet. With the initial pyvmomi release shipping type stubs (8.0.1.0), there are syntax errors in a few of the files, preventing their use completely with mypy (vmware/pyvmomi#1015), and beyond that it looks like there will be other issues as well.

I'm sure the upstream stubs will improve over time, just need to wait some more. November deadline seems reasonable.

The upside is that upstream type stubs look like they're autogenerated and very extensive, they cover all of the API surface, not just a few object types like types-pyvmomi.

@AlexWaygood
Copy link
Member

AlexWaygood commented May 10, 2023

Ah, thanks for letting us know. If the upstream type hints are completely unusable, maybe it would be better to revert #10148 for now. (With the stubs marked as obsolete, the description on PyPI tells users not to use types-pyvmomi anymore, which is obviously incorrect advice right now: https://pypi.org/project/types-pyvmomi/.) This is a pretty unusual situation, though.

@AlexWaygood
Copy link
Member

Okay, for now we've reverted marking the stubs as obsolete. We can mark types-pyvmomi as obsolete again once the upstream types are usable.

@intgr
Copy link
Contributor

intgr commented May 30, 2023

With the latest pyvmomi version 8.0.1.0.1 (May 25), the upstream type stubs work well with mypy for my use cases.

PyCharm still struggles with upstream types, but I have not investigated that in detail.

@AlexWaygood
Copy link
Member

"Upstream types don't work perfectly with all type checkers" feels like it falls into the category of "the stubs are somewhat buggy" rather than "the stubs are fundamentally broken". So I'd vote for marking types-pyvmomi as obsolete once more, in that case. Thanks for the update @intgr!

@AlexWaygood
Copy link
Member

Now marked as obsolete since 8.0.1.0.1: 2ec6ba9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stubs: removal Pending removal of third-party distributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants