Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how internal errors are propagated to users and when debugging issues #2738

Closed
abn opened this issue Jul 28, 2020 · 5 comments · Fixed by #2739
Closed

Improve how internal errors are propagated to users and when debugging issues #2738

abn opened this issue Jul 28, 2020 · 5 comments · Fixed by #2739
Labels
kind/enhancement Not a bug or feature, but improves usability or performance

Comments

@abn
Copy link
Member

abn commented Jul 28, 2020

As things stand today, the internal errors that happen when issues like #2737 #2734 are encountered are lost to the logger.

except ValueError:
# Likely unable to parse constraint so we skip it
self._log(
"Invalid constraint ({}) found in {}-{} dependencies, "
"skipping".format(req, package.name, package.version),
level="debug",
)
continue

This needs to be improved such that we use an application level logger with an option to generate debug logs if/when required without interfering with the CLI UX.

@abn abn added kind/feature Feature requests/implementations status/triage This issue needs to be triaged kind/enhancement Not a bug or feature, but improves usability or performance and removed kind/feature Feature requests/implementations labels Jul 28, 2020
@ewjoachim
Copy link

(perfect 👍 thank you)

@abn
Copy link
Member Author

abn commented Jul 28, 2020

@sdispater Is there some processing missing here?

PyPI: No release information found for django-1.1.2, skipping
PyPI: 1 packages found for django >=3.0.8,<4.0.0
<debug>PackageInfo:</debug> Invalid constraint (asgiref (~=3.2)) found in django-3.0.8 dependencies, skipping
   1: fact: django (3.0.8) depends on pytz (*)
   1: fact: django (3.0.8) depends on sqlparse (>=0.2.2)

I was expecting <debug> to be rendered correctly.

@sdispater
Copy link
Member

@abn It's rendered correctly on my end:

Screenshot 2020-07-28 at 17 00 33

@abn
Copy link
Member Author

abn commented Jul 28, 2020

@abn It's rendered correctly on my end:

Strange. Not sure why that single debug won't render as expected on mine. Will debug later then.

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants