Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to configure cibuildwheel shell (Github Actions). #1338

Closed
lithomas1 opened this issue Nov 11, 2022 · 1 comment · Fixed by #1346
Closed

Add support to configure cibuildwheel shell (Github Actions). #1338

lithomas1 opened this issue Nov 11, 2022 · 1 comment · Fixed by #1346

Comments

@lithomas1
Copy link

Description

Sometimes you don't want to run the build step under the bash shell, since on the bash shell things such as cl.exe are not part of the PATH.

This is relevant for projects building with meson, since meson is not smart enough to find your VS installation if it's not on the PATH.

Build log

No response

CI config

No response

@henryiii
Copy link
Contributor

henryiii commented Nov 11, 2022

You have to specify a shell when making a composite action (at least last I checked); you can't get the auto-change on platform behavior that you get normally with run:. Also, we use a bash-specific construct to avoid output interleaving. However, we could split it into two steps and put if: runner.os (I think if's are supported in composite actions). Also, the output interleaving issues are better now (I hope).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants