Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw arc test in draw_test.py #3230

Merged
merged 5 commits into from
Dec 1, 2024
Merged

Conversation

Akaracy
Copy link
Contributor

@Akaracy Akaracy commented Nov 20, 2024

I modified the test test_arc__correct_drawing() in draw_test.py as asked in #2636 and #2638 .
I added a wider range of widths and angles to test the arc function.

@Akaracy Akaracy requested a review from a team as a code owner November 20, 2024 10:36
@yunline yunline added tests tests (module) draw pygame.draw labels Nov 20, 2024
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing to pygame-ce 🥳
Thanks to the PR of the original author as well!

@ankith26 ankith26 added this to the 2.5.3 milestone Nov 27, 2024
@ankith26 ankith26 requested a review from MyreMylar November 27, 2024 11:48
@ankith26
Copy link
Member

Requesting Myre's review as they had reviewed the original PR

@ankith26 ankith26 linked an issue Nov 27, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for the contribution 😄 !

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@MyreMylar MyreMylar merged commit dfbe4d0 into pygame-community:main Dec 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draw pygame.draw tests tests (module)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Test for pygame.draw.arc in draw_test.py
6 participants