Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component bounds checking #3087

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix component bounds checking #3087

merged 1 commit into from
Sep 16, 2024

Conversation

ankith26
Copy link
Member

minor fix to address the unresolved review comment I had in #3069

@ankith26 ankith26 requested a review from a team as a code owner August 30, 2024 11:10
@bilhox bilhox added the Code quality/robustness Code quality and resilience to changes label Aug 30, 2024
@aatle
Copy link
Contributor

aatle commented Aug 31, 2024

Question, would it be any better to manually inline vector_set_component at its 3 places to get rid of bad internal call possibilities and the error switch statement?

@Starbuck5
Copy link
Member

Yeah, that could potentially be more performant. Who knows, maybe the compiler is smart enough to do the inlining and remove conditionals anyway.

But changing the way that works can happen another time, it shouldn’t stop this PR from happening imo.

Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@zoldalma999 zoldalma999 merged commit 0989f32 into main Sep 16, 2024
26 checks passed
@zoldalma999 zoldalma999 added this to the 2.5.2 milestone Sep 16, 2024
@ankith26 ankith26 deleted the ankith26-fix-set-comp-err branch September 16, 2024 17:56
@Starbuck5 Starbuck5 added the math pygame.math label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code quality/robustness Code quality and resilience to changes math pygame.math
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants