Undeprecate draw aaline blend #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
reviewed
Mar 9, 2024
I opened #2744 to apply the formatting changes. I can rebase this pull when that merges |
|
I think it’s fine to leave the feature removed (commits don’t need to be reverted). It’s just that the parameter should be un-removed and should always raise a depreciation warning. |
…ut it always raises an exception when used
oddbookworm
force-pushed
the
undeprecate-draw-aaline-blend
branch
from
674a0c2 to
9069359
Compare
Starbuck5
reviewed
Mar 13, 2024
src_c/draw.c
Outdated
| @@ -105,18 +105,29 @@ aaline(PyObject *self, PyObject *arg, PyObject *kwargs) | |||
| PyObject *colorobj, *start, *end; | |||
| SDL_Surface *surf = NULL; | |||
| float startx, starty, endx, endy; | |||
| PyObject *blend; | |||
There was a problem hiding this comment.
Shouldn't this start as null?
Starbuck5
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2739 and properly deprecates the blend argument so that if it's used, a warning will always be emitted instead of just false