Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2/SDL3 mutex support #2712

Merged
merged 1 commit into from
Feb 10, 2024
Merged

SDL2/SDL3 mutex support #2712

merged 1 commit into from
Feb 10, 2024

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Feb 6, 2024 •
edited
Loading

This gets the time module fully compiling, helps the event module as well (but event needs other patches).

Note from SDL3's readme-migration on mutexes:

SDL_LockMutex and SDL_UnlockMutex now return void; if the mutex is valid (including being a NULL pointer, which returns immediately), these functions never fail. If the mutex is invalid or the caller does something illegal, like unlock another thread's mutex, this is considered undefined behavior.

@Starbuck5 Starbuck5 requested a review from a team as a code owner February 6, 2024 08:41
@Starbuck5 Starbuck5 marked this pull request as draft February 6, 2024 08:41
@Starbuck5 Starbuck5 added sdl3 Code quality/robustness Code quality and resilience to changes and removed Code quality/robustness Code quality and resilience to changes labels Feb 6, 2024
@Starbuck5 Starbuck5 marked this pull request as ready for review February 6, 2024 08:58
oddbookworm
oddbookworm approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ankith26
ankith26 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has conflicts that need resolving, but apart that this PR LGTM! Thanks 🎈

@ankith26 ankith26 added this to the 2.5.0 milestone Feb 9, 2024
@Starbuck5 Starbuck5 merged commit 48ac487 into pygame-community:main Feb 10, 2024
29 of 30 checks passed
@Starbuck5 Starbuck5 deleted the sdl3-mutexes branch February 10, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

Assignees
No one assigned
Labels
sdl3
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Starbuck5 @ankith26 @oddbookworm