Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing special_flags links #2708

Merged

Conversation

itzpr3d4t0r
Copy link
Member

@itzpr3d4t0r itzpr3d4t0r commented Feb 4, 2024

Since the addition of a dedicated special_flags docs page (https://pyga.me/docs/ref/special_flags_list.html) Surface.blit was the only method that actually contained a link to the page. This PR adds the missing links to blits/fblits/fill.

@itzpr3d4t0r itzpr3d4t0r requested a review from a team as a code owner February 4, 2024 11:51
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea for a PR!

Some of these should be moved onto new lines, we've conventionally kept the line length in the rst files down where possible.

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@itzpr3d4t0r itzpr3d4t0r merged commit 8cd7afc into pygame-community:main Feb 9, 2024
2 checks passed
@itzpr3d4t0r itzpr3d4t0r added this to the 2.5.0 milestone Feb 9, 2024
Starbuck5 pushed a commit that referenced this pull request Feb 18, 2024
@Starbuck5 Starbuck5 modified the milestones: 2.5.0, 2.4.1 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants