Don't skip tests if "optional" modules are absent #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
approved these changes
Jan 4, 2024
MyreMylar
approved these changes
Jan 5, 2024
Starbuck5
pushed a commit
that referenced
this pull request
Feb 18, 2024
Don't skip tests if "optional" modules are absent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many "optional" modules. However these modules are widely used and most users would expect these to be present. So, we should run these tests so that the tests explicitly error when these modules are absent, to ensure that the person running the tests knows the modules are not compiled in (and not left out accidentally)
fixes #1569