Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Once cryptography minimal version is 41, do some relevant cleanup #1206

Closed
itamarst opened this issue Mar 28, 2023 · 4 comments
Closed

Once cryptography minimal version is 41, do some relevant cleanup #1206

itamarst opened this issue Mar 28, 2023 · 4 comments

Comments

@itamarst
Copy link
Contributor

Follow-up to #1202:

Once cryptography v40 is no longer supported, OpenSSL.SSL can expose X509_V_* constants unconditionally.

@h-vetinari
Copy link

This has actually become relevant now that cryptography 41.0.0 has been released, and is (nominally?) incompatible with the metadata in this package, which forces the constraint solver (of conda) into weird contortions that end up picking a very old pyopenssl that's not compatible with OpenSSL 3 for example.

Could we have a new release for pyopenssl, or alternatively, is it safe to remove the <41 cap in the dependency metadata?

CC @alex @reaperhulk @hmaarrfk

@reaperhulk
Copy link
Member

We're doing a release that raises the cap momentarily (a later release will raise the minimum).

@h-vetinari
Copy link

Thanks, that's great to hear!

(I realised too late that this issue was for once the minimum is 41.x, sorry)

@facutuesca
Copy link
Contributor

facutuesca commented Oct 3, 2023

This issue was created at a point where the linked PR (#1202) conditionally exposed the x509_V_* constants according to the available capabilities. However, before merge that conditional ended up being removed (source). The reason for that was that the problematic cryptography versions that required that conditional were blacklisted in setup.py, so the conditional was no longer needed.

So this issue is already fixed (the constants are already exposed unconditionally). And the setup.py blacklisting is already removed since the minimum cryptography version is at 41.0.0

cc @mhils @reaperhulk

@mhils mhils closed this as completed Oct 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants