-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bi2012 dependency #37
Closed
Closed
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
60d8dec
add bi2012 dataset and util function
gcattan 326624c
typo
gcattan c1cab2e
add iterator over bi2012 dataset
gcattan 4b99ad6
update documentation
gcattan 5a3c767
remove mne dependency
gcattan 8450f34
add same mne reference as in bi2012
gcattan 0a0e20b
update conf.py
gcattan 96251c9
workaround for datapath
gcattan e223a51
restart pipeline
gcattan 58e9743
update workaround
gcattan 5cb678e
missing
gcattan a39d982
try update_path
gcattan e490774
missing
gcattan d594a1a
remove update_path
gcattan 48bd549
remove mne version
gcattan 02c3114
try mne 0.20.1
gcattan c73df2e
revert modif to utils.py related to data_path
gcattan e75bf18
make bi2012 a required dependency
gcattan 75945c2
lower mne version
gcattan a863b8d
invalid syntax fixed
gcattan 0e80456
update index.rst
gcattan c786f54
Update doc/requirements.txt
gcattan 1aa8cd9
remove skeleton for bi2012_quantum_classify
gcattan 256ed31
Update pyriemann_qiskit/datasets/utils.py
gcattan 941fba5
Merge branch 'gc/bi2012_dependency' of https://github.com/gcattan/pyR…
gcattan a388976
refactor helper in utils.
gcattan 9dd179f
update setup.py
gcattan aa8609e
Update pyriemann_qiskit/datasets/utils.py
gcattan 97cc996
Update pyriemann_qiskit/datasets/utils.py
gcattan 4ffd1a2
Update pyriemann_qiskit/datasets/utils.py
gcattan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,4 +57,5 @@ Datasets | |
get_mne_sample | ||
get_linearly_separable_dataset | ||
get_qiskit_dataset | ||
get_bi2012_dataset | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,10 @@ | ||
from .utils import (get_mne_sample, | ||
get_linearly_separable_dataset, | ||
get_qiskit_dataset) | ||
get_qiskit_dataset, | ||
get_bi2012_dataset) | ||
|
||
|
||
__all__ = ["get_mne_sample", | ||
"get_linearly_separable_dataset", | ||
"get_qiskit_dataset"] | ||
"get_qiskit_dataset", | ||
"get_bi2012_dataset"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a good idea to freeze the MNE version, it should really be avoided. Is this because of bi2012 dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately yes. It is using
_fetch_file
which doesn t seem available in recent versions of mne:I have just opened an issue in bi2012, so we can keep trace of it.