Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KernelDMLCateEstimator Model final #157

Closed
vasilismsr opened this issue Nov 12, 2019 · 1 comment
Closed

KernelDMLCateEstimator Model final #157

vasilismsr opened this issue Nov 12, 2019 · 1 comment
Assignees
@kbattocchi
Labels
bug Something isn't working

Comments

@vasilismsr
Copy link
Contributor

The KernelDMLCateEstimator should not be a child of LinearDMLCateEstimator because this means that the model_final is an unregularized linear model. We should instead have the model final be a hard-coded elasticnet regularized model and the user can specify the alpha and the l1_ratio.
@vasilismsr vasilismsr added the bug Something isn't working label Nov 12, 2019
@vasilismsr vasilismsr mentioned this issue Nov 14, 2019
Merged
@kbattocchi
Copy link
Collaborator

Fixed by #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbattocchi kbattocchi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kbattocchi @vasilismsr