Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement another snow loss model like Bill Marion as an alt to pvwatts #577

Closed
mikofski opened this issue Sep 13, 2018 · 10 comments · Fixed by #764
Closed

Implement another snow loss model like Bill Marion as an alt to pvwatts #577

mikofski opened this issue Sep 13, 2018 · 10 comments · Fixed by #764
Milestone

Comments

@mikofski
Copy link
Member

I'll try to track down the papers on this

@wholmgren wholmgren added this to the Someday milestone Nov 2, 2018
@anomam
Copy link
Contributor

anomam commented Apr 16, 2019

Hello folks, @mikofski @wholmgren @cwhanse
My group would like to open-source in pvlib the snow model that Defne Gun presented at the 10th PVPMC workshop in 2018: see link to workshop website and link to presentation.
I also talked with Dan Riley (do you know his Github username? I would like to tag him) and it seems that it would be very useful for ongoing research to have that model implemented so that his group can build on top of it.
Would that be ok? Please let us know if there are any concerns.

@mikofski
Copy link
Member Author

ICYMI @patrickjmathiesen

@mikofski
Copy link
Member Author

I'd still like to see Bill Marion's model here, but I think it would be great to see the SunPower model too, thanks!

@DanRiley
Copy link

I think that Defne's additions are just on top of Bill's model, so I'm hopeful that by getting Defne's model that we would also get Bill's. I'll be working on getting both of them into MATLAB pv_lib.

@cwhanse
Copy link
Member

cwhanse commented Apr 16, 2019

Thanks for the initiative on this. Two questions to help identify where to put the code:

  • Does the model modify irradiance or power?
  • What system characteristics are needed beyond tilt and azimuth? It appears that a length dimension and height above ground are needed.

@cwhanse
Copy link
Member

cwhanse commented Jun 25, 2019

@ryanblumie @kevinsa5 Ryan let's discuss your offer here

@mikofski
Copy link
Member Author

mikofski commented Jun 26, 2019

FYI: DNV GL would also like to contribute the Townsend snow model, I have 3 references. The inputs are typically daily snowfall history, gcr, module lower edge height above ground, ambient temperature, and the output is binary: no power due to snow cover, or power. AFAIK there is no partial power. We already have the code ready.

@cwhanse
Copy link
Member

cwhanse commented Jun 26, 2019

@mikofski inputs are similar to Marion's model. As far as pvlib, we need to decide where to record the inputs and how to name them. Tossing one idea out:
PVSystem.height_above_ground
PVSystem.gcr - need to move from SingleAxisTracker.gcr
Daily snowfall doesn't fit nicely in weather due to the expected daily timesteps. Ideas for a nice way to host snowfall/rainfall other daily values (turbidity perhaps)?

@wholmgren
Copy link
Member

Daily snowfall doesn't fit nicely in weather due to the expected daily timesteps. Ideas for a nice way to host snowfall/rainfall other daily values (turbidity perhaps)?

Is this only a concern for integrating the snow loss model with ModelChain.run_model(weather) or do we need to address it when implementing the basic function?

@cwhanse
Copy link
Member

cwhanse commented Jun 26, 2019

The concern is for ModelChain The basic function should expect to get the inputs that the model requires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants